Instant cleanup: remove MODE_SEARCH_RESULTS and ORIGIN_SEARCH

Instant cleanup: remove MODE_SEARCH_RESULTS and ORIGIN_SEARCH
That mode/origin was never set outside of tests. Removing it also allows us to remove some more dead code paths.

BUG=627747
Committed: https://crrev.com/b6b5209c9e7c0204d32aa0f62514468526f84c1e
Cr-Commit-Position: refs/heads/master@{#416539}

[Marc Treib, 2016-09-02 13:49:57]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 13:50:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2016-09-02 13:53:06]

Description was changed from

==========
Instant cleanup: remove MODE_SEARCH_RESULTS and ORIGIN_SEARCH

BUG=627747
==========

to

==========
Instant cleanup: remove MODE_SEARCH_RESULTS and ORIGIN_SEARCH
That mode/origin was never set outside of tests.

BUG=627747
==========

[Marc Treib, 2016-09-02 13:54:21]

Description was changed from

==========
Instant cleanup: remove MODE_SEARCH_RESULTS and ORIGIN_SEARCH
That mode/origin was never set outside of tests.

BUG=627747
==========

to

==========
Instant cleanup: remove MODE_SEARCH_RESULTS and ORIGIN_SEARCH
That mode/origin was never set outside of tests. Removing it also allows us to
remove some more dead code paths.

BUG=627747
==========

[commit-bot: I haz the power, 2016-09-02 14:38:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 14:38:09]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-09-02 14:47:46]

treib@chromium.org changed reviewers:
+ pkasting@chromium.org

[Marc Treib, 2016-09-02 14:47:46]

Now that the other CLs finally landed, here's the next part. PTAL, thanks!

[Peter Kasting, 2016-09-02 20:41:00]

LGTM

https://codereview.chromium.org/2269933002/diff/20001/chrome/browser/ui/searc...
File chrome/browser/ui/search/instant_controller.cc (right):

https://codereview.chromium.org/2269933002/diff/20001/chrome/browser/ui/searc...
chrome/browser/ui/search/instant_controller.cc:22: #include
"content/public/browser/navigation_controller.h"
I think this #include is dead.  Please check all other #includes as well.

https://codereview.chromium.org/2269933002/diff/20001/chrome/browser/ui/searc...
File chrome/browser/ui/search/instant_controller.h (right):

https://codereview.chromium.org/2269933002/diff/20001/chrome/browser/ui/searc...
chrome/browser/ui/search/instant_controller.h:25: struct
EmbeddedSearchRequestParams;
Nit: This forward-decl is no longer necessary

https://codereview.chromium.org/2269933002/diff/20001/chrome/common/search/se...
File chrome/common/search/search_types.h (left):

https://codereview.chromium.org/2269933002/diff/20001/chrome/common/search/se...
chrome/common/search/search_types.h:56: bool is_default() const {
Nit: Suggestion for followup: Now that no remaining accessors check multiple
enum values, perhaps all these is_xxx() functions should just become two const
getters, one each for the mode and the origin.

(I wonder if the whole concept of the possible search modes, whether they should
be enums, what the enums should be, etc. itself could be rethought and
simplified, but that's a larger issue.)

[Marc Treib, 2016-09-05 12:11:16]

https://codereview.chromium.org/2269933002/diff/20001/chrome/browser/ui/searc...
File chrome/browser/ui/search/instant_controller.cc (right):

https://codereview.chromium.org/2269933002/diff/20001/chrome/browser/ui/searc...
chrome/browser/ui/search/instant_controller.cc:22: #include
"content/public/browser/navigation_controller.h"
On 2016/09/02 20:40:59, Peter Kasting wrote:
> I think this #include is dead.  Please check all other #includes as well.

Done.

https://codereview.chromium.org/2269933002/diff/20001/chrome/browser/ui/searc...
File chrome/browser/ui/search/instant_controller.h (right):

https://codereview.chromium.org/2269933002/diff/20001/chrome/browser/ui/searc...
chrome/browser/ui/search/instant_controller.h:25: struct
EmbeddedSearchRequestParams;
On 2016/09/02 20:40:59, Peter Kasting wrote:
> Nit: This forward-decl is no longer necessary

Done.

https://codereview.chromium.org/2269933002/diff/20001/chrome/common/search/se...
File chrome/common/search/search_types.h (left):

https://codereview.chromium.org/2269933002/diff/20001/chrome/common/search/se...
chrome/common/search/search_types.h:56: bool is_default() const {
On 2016/09/02 20:40:59, Peter Kasting wrote:
> Nit: Suggestion for followup: Now that no remaining accessors check multiple
> enum values, perhaps all these is_xxx() functions should just become two const
> getters, one each for the mode and the origin.
> 
> (I wonder if the whole concept of the possible search modes, whether they
should
> be enums, what the enums should be, etc. itself could be rethought and
> simplified, but that's a larger issue.)

I think we can get rid of Origin completely (ORIGIN_NTP is used in only a single
place, and that can hopefully be done another way), and then collapse this whole
thing to a simple enum. Another day... :)

[Marc Treib, 2016-09-05 12:11:24]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 12:11:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 13:19:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 13:19:56]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-09-05 13:21:56]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2016-09-05 13:21:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2269933002/#ps60001
(title: "review")

[commit-bot: I haz the power, 2016-09-05 13:22:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 13:25:52]

Description was changed from

==========
Instant cleanup: remove MODE_SEARCH_RESULTS and ORIGIN_SEARCH
That mode/origin was never set outside of tests. Removing it also allows us to
remove some more dead code paths.

BUG=627747
==========

to

==========
Instant cleanup: remove MODE_SEARCH_RESULTS and ORIGIN_SEARCH
That mode/origin was never set outside of tests. Removing it also allows us to
remove some more dead code paths.

BUG=627747
==========

[commit-bot: I haz the power, 2016-09-05 13:25:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-05 13:27:47]

Description was changed from

==========
Instant cleanup: remove MODE_SEARCH_RESULTS and ORIGIN_SEARCH
That mode/origin was never set outside of tests. Removing it also allows us to
remove some more dead code paths.

BUG=627747
==========

to

==========
Instant cleanup: remove MODE_SEARCH_RESULTS and ORIGIN_SEARCH
That mode/origin was never set outside of tests. Removing it also allows us to
remove some more dead code paths.

BUG=627747

Committed: https://crrev.com/b6b5209c9e7c0204d32aa0f62514468526f84c1e
Cr-Commit-Position: refs/heads/master@{#416539}
==========

[commit-bot: I haz the power, 2016-09-05 13:27:48]

Patchset 4 (id:??) landed as
https://crrev.com/b6b5209c9e7c0204d32aa0f62514468526f84c1e
Cr-Commit-Position: refs/heads/master@{#416539}