components/toolbar/toolbar_model.cc - Issue 2242213008: Remove url_replacement logic from Omnibox/ToolbarModel

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/toolbar/toolbar_model.cc

Issue 2242213008: Remove url_replacement logic from Omnibox/ToolbarModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_show_url

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/toolbar/toolbar_model.h"	5 #include "components/toolbar/toolbar_model.h"

6	6

7 ToolbarModel::ToolbarModel()	7 ToolbarModel::ToolbarModel()

8 : input_in_progress_(false),	8 : input_in_progress_(false) {
	Peter Kasting 2016/08/19 22:40:06 Nit: Can be on previous line I might just inline Nit: Can be on previous line I might just inline this into the header. Marc Treib 2016/08/22 08:45:55 Done. Show quoted text On 2016/08/19 22:40:06, Peter Kasting wrote: > Nit: Can be on previous line > > I might just inline this into the header. Done.
9 url_replacement_enabled_(true) {

10 }	9 }

11	10

12 ToolbarModel::~ToolbarModel() {	11 ToolbarModel::~ToolbarModel() {
	Peter Kasting 2016/08/19 22:40:06 Nit: I'd remove this and just use =default in the Nit: I'd remove this and just use =default in the .h Marc Treib 2016/08/22 08:45:55 Done. Show quoted text On 2016/08/19 22:40:06, Peter Kasting wrote: > Nit: I'd remove this and just use =default in the .h Done.
13 }	12 }

OLD	NEW

« components/omnibox/browser/omnibox_edit_model.cc ('K') | « components/toolbar/toolbar_model.h ('k') | no next file » | no next file with comments »