components/omnibox/browser/omnibox_view.cc - Issue 2242213008: Remove url_replacement logic from Omnibox/ToolbarModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/omnibox_view.cc

Issue 2242213008: Remove url_replacement logic from Omnibox/ToolbarModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_show_url

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/omnibox/browser/omnibox_view.cc

diff --git a/components/omnibox/browser/omnibox_view.cc b/components/omnibox/browser/omnibox_view.cc

index ab062677182c790717b90860959396593e13833f..d471fb120c2192eecd663ff6b495518e85dfa034 100644

--- a/components/omnibox/browser/omnibox_view.cc

+++ b/components/omnibox/browser/omnibox_view.cc

@@ -113,11 +113,6 @@ void OmniboxView::SetUserText(const base::string16& text,

}

void OmniboxView::RevertAll() {

- controller_->GetToolbarModel()->set_url_replacement_enabled(true);

- RevertWithoutResettingSearchTermReplacement();

-void OmniboxView::RevertWithoutResettingSearchTermReplacement() {

CloseOmniboxPopup();

if (model_.get())

model_->Revert();

« no previous file with comments | « components/omnibox/browser/omnibox_view.h ('k') | components/toolbar/BUILD.gn » ('j') | no next file with comments »