Remove ShowURL/HideURL from OmniboxView and LocationBarView

Remove ShowURL/HideURL from OmniboxView and LocationBarView.
They're not used anymore.

Follow-up to https://codereview.chromium.org/2232863002/

BUG=627747
Committed: https://crrev.com/b566b98f807b4b81f3d00801aaa1bd497609ebab
Cr-Commit-Position: refs/heads/master@{#416215}

[Marc Treib, 2016-08-17 09:23:35]

Description was changed from

==========
Remove ShowURL/HideURL

They're not used anymore.

Follow-up to https://codereview.chromium.org/2232863002/

BUG=627747
==========

to

==========
Remove ShowURL/HideURL from OmniboxView and LocationBarView.
They're not used anymore.

Follow-up to https://codereview.chromium.org/2232863002/

BUG=627747
==========

[Marc Treib, 2016-08-18 08:25:05]

treib@chromium.org changed reviewers:
+ pkasting@chromium.org

[Marc Treib, 2016-08-18 08:25:06]

The next installment of the saga - PTAL!

[Peter Kasting, 2016-08-18 08:32:19]

LGTM

https://codereview.chromium.org/2256613002/diff/40001/components/omnibox/brow...
File components/omnibox/browser/omnibox_view.cc (left):

https://codereview.chromium.org/2256613002/diff/40001/components/omnibox/brow...
components/omnibox/browser/omnibox_view.cc:117:
controller_->GetToolbarModel()->set_url_replacement_enabled(false);
This was the only place outside tests that set this to false, so you should be
good to rip out this setter and remove the corresponding tests now.

That will also mean that RevertAll() will simply become a call to
RvertWithoutResettingSearchTermReplacement(), so the two should just be
collapsed into one RevertAll() method at the same time.

[Marc Treib, 2016-08-18 09:10:20]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 09:10:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2016-08-18 09:10:38]

https://codereview.chromium.org/2256613002/diff/40001/components/omnibox/brow...
File components/omnibox/browser/omnibox_view.cc (left):

https://codereview.chromium.org/2256613002/diff/40001/components/omnibox/brow...
components/omnibox/browser/omnibox_view.cc:117:
controller_->GetToolbarModel()->set_url_replacement_enabled(false);
On 2016/08/18 08:32:19, Peter Kasting wrote:
> This was the only place outside tests that set this to false, so you should be
> good to rip out this setter and remove the corresponding tests now.

Ah, I hadn't noticed that yet, thanks! Next CL incoming soon :)

> That will also mean that RevertAll() will simply become a call to
> RvertWithoutResettingSearchTermReplacement(), so the two should just be
> collapsed into one RevertAll() method at the same time.

Acknowledged.

[commit-bot: I haz the power, 2016-08-18 09:26:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 09:26:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Marc Treib, 2016-08-18 11:11:52]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 11:12:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2016-08-18 11:12:12]

treib@chromium.org changed reviewers:
+ dtseng@chromium.org

[Marc Treib, 2016-08-18 11:12:13]

+dtseng for sticky_keys_browsertest.cc, PTAL!

[commit-bot: I haz the power, 2016-08-18 11:55:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 11:55:31]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-08-22 08:04:32]

On 2016/08/18 11:12:13, Marc Treib wrote:
> +dtseng for sticky_keys_browsertest.cc, PTAL!

Ping! dtseng, could you take a look at sticky_keys_browsertest.cc please?
Thanks!

[Marc Treib, 2016-08-23 08:22:49]

treib@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[Marc Treib, 2016-08-23 08:22:50]

+dmazzoni, since dtseng seems to be out. Could you take a look at
sticky_keys_browsertest.cc please? Thanks!

[Marc Treib, 2016-08-25 10:38:37]

On 2016/08/23 08:22:50, Marc Treib wrote:
> +dmazzoni, since dtseng seems to be out. Could you take a look at
> sticky_keys_browsertest.cc please? Thanks!

Ping dmazzoni and/or dtseng!

[Marc Treib, 2016-08-30 11:01:32]

treib@chromium.org changed reviewers:
+ plundblad@chromium.org

[Marc Treib, 2016-08-30 11:01:32]

..and adding the final owner of chromeos/accessibility. plundblad, could you
take a look at sticky_keys_browsertest.cc please?

[Marc Treib, 2016-09-01 11:45:38]

Ping! dtseng, dmazzoni, plundblad, can either of you please take a look at
sticky_keys_browsertest.cc?

[dmazzoni, 2016-09-01 17:37:01]

lgtm

[Marc Treib, 2016-09-02 08:12:55]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 08:13:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 09:00:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 09:00:21]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-09-02 09:02:27]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2016-09-02 09:02:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org, dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2256613002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-02 09:02:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 09:06:36]

Description was changed from

==========
Remove ShowURL/HideURL from OmniboxView and LocationBarView.
They're not used anymore.

Follow-up to https://codereview.chromium.org/2232863002/

BUG=627747
==========

to

==========
Remove ShowURL/HideURL from OmniboxView and LocationBarView.
They're not used anymore.

Follow-up to https://codereview.chromium.org/2232863002/

BUG=627747
==========

[commit-bot: I haz the power, 2016-09-02 09:06:38]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-02 09:08:22]

Description was changed from

==========
Remove ShowURL/HideURL from OmniboxView and LocationBarView.
They're not used anymore.

Follow-up to https://codereview.chromium.org/2232863002/

BUG=627747
==========

to

==========
Remove ShowURL/HideURL from OmniboxView and LocationBarView.
They're not used anymore.

Follow-up to https://codereview.chromium.org/2232863002/

BUG=627747

Committed: https://crrev.com/b566b98f807b4b81f3d00801aaa1bd497609ebab
Cr-Commit-Position: refs/heads/master@{#416215}
==========

[commit-bot: I haz the power, 2016-09-02 09:08:25]

Patchset 5 (id:??) landed as
https://crrev.com/b566b98f807b4b81f3d00801aaa1bd497609ebab
Cr-Commit-Position: refs/heads/master@{#416215}