|
Adds DevTools commands for forced viewport override to the Emulation domain.
They are handled by the renderer's DevToolsEmulator.
This is a second step towards more flexible screenshots
(bit.ly/sized-screenshots): With this override, we can position a specific
(scaled) area of the page into the top-left corner of the frame. We can then
take a screenshot after resizing the frame (RWHV) in the browser to the scaled
area size. We are adding DevTools commands for the latter in a separate patch:
https://codereview.chromium.org/2226323002/
We enforce the override through the root layer transform of WebViewImpl.
As the given area coordinates are relative to the page origin and a page
scale of 1.0, we take the current scroll offset and page scale into account
and update the root transform when they change.
To ensure that all content in the area is recorded and shown, we override
the visible content area used in CompositedLayerMapping and disable clipping
to the visual viewport while the override is active.
BUG= 625577
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Committed: https://crrev.com/23d8f263fccca2ef163a9c3f1592d3a51e3a2d50
Cr-Commit-Position: refs/heads/master@{#420314}
Total comments: 8
Total comments: 2
Total comments: 8
Total comments: 4
Total comments: 17
Total comments: 20
Total comments: 8
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+846 lines, -43 lines) |
Patch |
|
M |
content/browser/devtools/protocol/emulation_handler.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/renderer/devtools/render_widget_screen_metrics_emulator.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
content/renderer/gpu/render_widget_compositor.h
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
content/renderer/gpu/render_widget_compositor.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-far.html
|
View
|
1
2
3
4
5
6
|
1 chunk |
+59 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-far-expected.html
|
View
|
1
2
3
4
5
6
|
1 chunk |
+29 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-far-layered.html
|
View
|
1
2
3
4
5
6
|
1 chunk |
+60 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-far-layered-expected.html
|
View
|
1
2
3
4
5
6
|
1 chunk |
+29 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-near.html
|
View
|
1
2
3
4
5
6
|
1 chunk |
+64 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-near-expected.html
|
View
|
1
2
3
4
5
6
|
1 chunk |
+29 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-reset.html
|
View
|
1
2
3
4
5
6
|
1 chunk |
+64 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-reset-expected.html
|
View
|
1
2
3
4
5
6
|
1 chunk |
+42 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-unobserved.html
|
View
|
1
2
3
4
5
6
|
1 chunk |
+47 lines, -0 lines |
0 comments
|
Download
|
|
A |
third_party/WebKit/LayoutTests/inspector-protocol/emulation/forced-viewport-unobserved-expected.txt
|
View
|
1
2
3
4
5
6
|
1 chunk |
+7 lines, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/frame/FrameView.h
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
2 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/frame/FrameView.cpp
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
3 chunks |
+20 lines, -1 line |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/frame/VisualViewport.cpp
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/inspector/browser_protocol.json
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
2 chunks |
+17 lines, -2 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
3 chunks |
+10 lines, -10 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/page/ChromeClient.h
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/platform/graphics/GraphicsLayer.h
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.h
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
1 chunk |
+7 lines, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/web/ChromeClientImpl.h
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/web/ChromeClientImpl.cpp
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
4 chunks |
+12 lines, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/web/DevToolsEmulator.h
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
2 chunks |
+32 lines, -1 line |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/web/DevToolsEmulator.cpp
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
4 chunks |
+119 lines, -2 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/web/InspectorEmulationAgent.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/web/InspectorEmulationAgent.cpp
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
4 chunks |
+35 lines, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/web/WebViewImpl.h
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
3 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/web/WebViewImpl.cpp
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
5 chunks |
+17 lines, -13 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
|
View
|
1
2
3
4
5
6
7
8
9
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/web/tests/WebViewTest.cpp
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
3 chunks |
+105 lines, -0 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/public/platform/WebLayerTreeView.h
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
Dependent Patchsets:
Total messages: 95 (49 generated)
|