third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp - Issue 2237433004: Adds DevTools commands for forced viewport override.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp

Issue 2237433004: Adds DevTools commands for forced viewport override. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adress Dmitry's comments + sync. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('k') | third_party/WebKit/Source/core/page/ChromeClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp

index 900bf9ccccca64474ff9976948106842c53a7e81..c11f680b01acfb761d6694d30e1f3bba896c1ea8 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp

@@ -103,8 +103,8 @@ TEST_F(CompositedLayerMappingTest, TallLayerWholeDocumentInterestRect)

PaintLayer* paintLayer = toLayoutBoxModelObject(element->layoutObject())->layer();

ASSERT_TRUE(paintLayer->graphicsLayerBacking());

ASSERT_TRUE(paintLayer->compositedLayerMapping());

- // recomputeInterestRect computes the interest rect; computeInterestRect applies the extra setting to paint everything.

- EXPECT_RECT_EQ(IntRect(0, 0, 200, 4592), recomputeInterestRect(paintLayer->graphicsLayerBacking()));

+ // Clipping is disabled in recomputeInterestRect.

+ EXPECT_RECT_EQ(IntRect(0, 0, 200, 10000), recomputeInterestRect(paintLayer->graphicsLayerBacking()));

EXPECT_RECT_EQ(IntRect(0, 0, 200, 10000), computeInterestRect(paintLayer->compositedLayerMapping(), paintLayer->graphicsLayerBacking(), IntRect()));

}

@@ -112,8 +112,6 @@ TEST_F(CompositedLayerMappingTest, VerticalRightLeftWritingModeDocument)

{

setBodyInnerHTML("<style>html,body { margin: 0px } html { -webkit-writing-mode: vertical-rl}</style> <div id='target' style='width: 10000px; height: 200px;'></div>");

- document().settings()->setMainFrameClipsContent(false);

document().view()->updateAllLifecyclePhases();

document().view()->setScrollPosition(DoublePoint(-5000, 0), ProgrammaticScroll);

document().view()->updateAllLifecyclePhases();