Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2332273003: Use updated interest rect when layer needs repainting. (Closed)

Created:
4 years, 3 months ago by Eric Seckler
Modified:
4 years, 3 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, dgozman, chrishtr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use updated interest rect when layer needs repainting. This ensures that repaints don't use a larger rect than necessary, while also ensuring that a new interest rect that is contained within the previous interest rect doesn't cause a repaint on its own. Currently, the previous interest rect is used if it didn't change too much even when the layer needs repainting, as introduced in https://codereview.chromium.org/1441973003. The original rationale behind this behavior was to ensure consistency between blink and cc. With cc refactorings, this should not be an issue any longer. BUG=646410 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/2a7731726042f2668cc5af06f106a616620f11e9 Cr-Commit-Position: refs/heads/master@{#418291}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp View 3 chunks +23 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Eric Seckler
Xianzhu, would you be happy with landing this change and monitoring for any potential regressions? ...
4 years, 3 months ago (2016-09-13 16:45:15 UTC) #8
Xianzhu
lgtm
4 years, 3 months ago (2016-09-13 16:59:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332273003/1
4 years, 3 months ago (2016-09-13 17:50:14 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 17:55:57 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 17:57:14 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a7731726042f2668cc5af06f106a616620f11e9
Cr-Commit-Position: refs/heads/master@{#418291}

Powered by Google App Engine
This is Rietveld 408576698