Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: third_party/WebKit/public/platform/WebLayerTreeView.h

Issue 2237433004: Adds DevTools commands for forced viewport override. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove offset/scale params, rename commands, clip by backing size. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 virtual void setRootLayer(const WebLayer&) { } 60 virtual void setRootLayer(const WebLayer&) { }
61 virtual void clearRootLayer() { } 61 virtual void clearRootLayer() { }
62 62
63 // TODO(loyso): These should use CompositorAnimationTimeline. crbug.com/5845 51 63 // TODO(loyso): These should use CompositorAnimationTimeline. crbug.com/5845 51
64 virtual void attachCompositorAnimationTimeline(cc::AnimationTimeline*) { } 64 virtual void attachCompositorAnimationTimeline(cc::AnimationTimeline*) { }
65 virtual void detachCompositorAnimationTimeline(cc::AnimationTimeline*) { } 65 virtual void detachCompositorAnimationTimeline(cc::AnimationTimeline*) { }
66 66
67 // View properties --------------------------------------------------- 67 // View properties ---------------------------------------------------
68 68
69 virtual void setViewportSize(const WebSize& deviceViewportSize) { } 69 virtual void setViewportSize(const WebSize& deviceViewportSize) { }
70 virtual WebSize getViewportSize() const { return WebSize(); }
chrishtr 2016/08/22 22:00:42 In what coordinate space? Not including the device
Eric Seckler 2016/08/23 09:32:19 It's in physical pixels. Added a comment.
70 71
71 virtual void setDeviceScaleFactor(float) { } 72 virtual void setDeviceScaleFactor(float) { }
73 virtual float getDeviceScaleFactor() const { return 1.f; }
dgozman 2016/08/22 22:22:06 Having both set and get here looks strange. AFAIU,
Eric Seckler 2016/08/23 09:32:19 True, except that there could be a device_scale_fa
72 74
73 // Sets the background color for the viewport. 75 // Sets the background color for the viewport.
74 virtual void setBackgroundColor(WebColor) { } 76 virtual void setBackgroundColor(WebColor) { }
75 77
76 // Sets the background transparency for the viewport. The default is 'false' . 78 // Sets the background transparency for the viewport. The default is 'false' .
77 virtual void setHasTransparentBackground(bool) { } 79 virtual void setHasTransparentBackground(bool) { }
78 80
79 // Sets whether this view is visible. In threaded mode, a view that is not v isible will not 81 // Sets whether this view is visible. In threaded mode, a view that is not v isible will not
80 // composite or trigger updateAnimations() or layout() calls until it become s visible. 82 // composite or trigger updateAnimations() or layout() calls until it become s visible.
81 virtual void setVisible(bool) { } 83 virtual void setVisible(bool) { }
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 // Toggles the debug borders on layers 169 // Toggles the debug borders on layers
168 virtual void setShowDebugBorders(bool) { } 170 virtual void setShowDebugBorders(bool) { }
169 171
170 // Toggles scroll bottleneck rects on the HUD layer 172 // Toggles scroll bottleneck rects on the HUD layer
171 virtual void setShowScrollBottleneckRects(bool) { } 173 virtual void setShowScrollBottleneckRects(bool) { }
172 }; 174 };
173 175
174 } // namespace blink 176 } // namespace blink
175 177
176 #endif // WebLayerTreeView_h 178 #endif // WebLayerTreeView_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698