Landing Recent QUIC changes until 4AM, Aug 7, 2016 UTC-4

Landing Recent QUIC changes until 4AM, Aug 7, 2016 UTC-4

Update quic flags.
https://codereview.chromium.org/2233943002/#ps40001

Removing obselete TODO
Merge internal change: 129550025
https://codereview.chromium.org/2228403004/#ps20001

Fix bug in QUIC force HOL blocking experiment, guarded by --quic_enable_version_36_v2.
Make sure that new QUIC paramenter FHOL (force head of line blocking)
propagates to and from CHLO correctly.
Merge internal change: 129481622
https://codereview.chromium.org/2230223003/#ps20001

Refactor SendAlgorithmSimulator to accept arbitrary termination predicates
Also, correct the description of SendAlgorithmSimulator::TransferBytes() to
reflect its actual behavior.
n/a (test-only change)
Merge internal change: 129468670
https://codereview.chromium.org/2236533002/#ps20001

Adding a test utility to print QuicTagValueMaps.
Merge internal change: 129456177
https://codereview.chromium.org/2236513002/#ps20001

Rename QuicSupportedVersions to QuicAllSupportedVersions. Add QuicCurrentSupportedVersions which returns filtered supported versions based on flags. Not flag protected.
Merge internal change: 129440821
https://codereview.chromium.org/2236463004/#ps40001

Test only. Fix quic e2e test flakiness caused by quic_buffer_packet_till_chlo.
Add this flag into test argument permutation to avoid testing cheap
stateless reject without enabling buffering out of order packets.
Merge internal change: 129437595
https://codereview.chromium.org/2231463003/#ps20001

Introduce TTL in QuicReceivedPacket.
Merge internal change: 129363578
https://codereview.chromium.org/2229703003/#ps20001

Change use of std::tuple/std::get to testing::tuple/testing::get so that parameterized test in quic_headers_stream_test.cc compiles not only for internal and chromium, but also for the proto-quic environment.
n/a (Testing only.)
Merge internal change: 129359661
https://codereview.chromium.org/2233453002/#ps20001

Fix memory corruption from SetMaxPacingRate by inlining PacingSender.
This behavior can be disabled by setting
quic_disable_pacing_for_perf_tests to true.
Merge internal change: 129356268
https://codereview.chromium.org/2228783004/#ps20001

Track when QUIC connections are application limited. Protected by quic_enable_app_limited_check.
This CL notifies the congestion control algorithm when the connection
has no outstanding data to send. No behavior change is expected.
Merge internal change: 129351671
https://codereview.chromium.org/2229023002/#ps20001

Make QuicDispatcher to queue packets for new connections while waiting for CHLOs. Flag protected by --quic_buffer_packet_till_chlo
Merge internal change: 129327247
https://codereview.chromium.org/2222393002/#ps20001

QuicSession no longer directly owns its QuicConnection. Not flag protected.
Merge internal change: 129318081
https://codereview.chromium.org/2226643004/

Add VersionOfIndex() to quic_protocol.h
Merge internal change: 129226757
https://codereview.chromium.org/2220333003/

Increments spdy_framer_use_new_methods2 to spdy_framer_use_new_methods3.
Merge internal change: 129220409
https://codereview.chromium.org/2225153002/

Use the CHLO packet size, not message size when determining how large a REJ can be. Protected by --quic_use_chlo_packet_size
This should reduce number of round trips during the handshake slightly.
Merge internal change: 129160718
https://codereview.chromium.org/2227553003/

Rollback of internal changelist 128865569.
*** Original change description ***
Inline PacingSender into QuicSentPacketManager. Guarded by
quic_use_inline_pacing.
***
Merge internal change: 129101660
https://codereview.chromium.org/2228613002/

Add GetDebugState() in SendAlgorithmInterface().
Merge internal change: 129053230
https://codereview.chromium.org/2222093002/

Remove v33 connection id public flags hack. Protected by --quic_remove_v33_hacks.
Merge internal change: 129015386
https://codereview.chromium.org/2223993002/

Deprecate --quic_socket_walltimestamps
Merge internal change: 129001103
https://codereview.chromium.org/2229553003/

Deprecate --quic_do_not_migrate_on_old_packet.
Merge internal change: 128998762
https://codereview.chromium.org/2221093002/

Flatten GeneralLossAlgorithm into QuicSentPacketManager. Not flag protected.
Also reorder GeneralLossAlgorithm per the class layout optimizer
recommendation.
Merge internal change: 128997036
https://codereview.chromium.org/2223983002/

Committed: https://crrev.com/3134c2563efdae541721a494b267c24dfea155ca
Cr-Commit-Position: refs/heads/master@{#411638}

[danzh1, 2016-08-11 15:07:39]

Description was changed from

==========
more updated files out of net/


change files not in net/


Update quic flags.


Removing obselete TODO

n/a (removing obselete TODO)

Merge internal change: 129550025

fix bug in QUIC force HOL blocking experiment, guarded by
--quic_enable_version_36_v2.

Make sure that new QUIC paramenter FHOL (force head of line blocking)
propagates to and from CHLO correctly.

Merge internal change: 129481622

Refactor SendAlgorithmSimulator to accept arbitrary termination predicates

Also, correct the description of SendAlgorithmSimulator::TransferBytes()
to
reflect its actual behavior.

n/a (test-only change)

Merge internal change: 129468670

Adding a test utility to print QuicTagValueMaps.

Merge internal change: 129456177

Rename QuicSupportedVersions to QuicAllSupportedVersions. Add
QuicCurrentSupportedVersions which returns filtered supported versions based on
flags. Not flag protected.

Merge internal change: 129440821

add new file


add copy right


commit newly added files


Test only. Fix quic e2e test flakiness caused by quic_buffer_packet_till_chlo.

Add this flag into test argument permutation to avoid testing cheap
stateless reject without enabling buffering out of order packets.

Merge internal change: 129437595

Introduce TTL in QuicReceivedPacket.

Merge internal change: 129363578

Change use of std::tuple/std::get to testing::tuple/testing::get so that
parameterized test in quic_headers_stream_test.cc compiles not only for internal
and chromium, but also for the proto-quic environment.

n/a (Testing only.)

Merge internal change: 129359661

Fix memory corruption from SetMaxPacingRate by inlining PacingSender.

This behavior can be disabled by setting
quic_disable_pacing_for_perf_tests to
true.


Merge internal change: 129356268

Track when QUIC connections are application limited. Protected by
quic_enable_app_limited_check.

This CL notifies the congestion control algorithm when the connection
has no outstanding data to send. No behavior change is expected.

Merge internal change: 129351671

reorder #include again


reorder #include


Make QuicDispatcher to queue packets for new connections while waiting for
CHLOs. Flag protected by --quic_buffer_packet_till_chlo

Merge internal change: 129327247

QuicSession no longer directly owns its QuicConnection. Not flag protected.

Merge internal change: 129318081

Make quic_proxy_backend_connection and quic_backend_connection talk single
version to avoid version negotiation. Default to be highest supported version.

Merge internal change: 129226757

Increments --spdy_framer_use_new_methods2.

Avoid possible lifetime races by having SpdyDispatcher own the
HeadersHandler until all headers in the current block have been framed,
delaying the ownership transfer to the relevant DispatcherFdWrapper.

Increments spdy_framer_use_new_methods2 to spdy_framer_use_new_methods3.

Merge internal change: 129220409

Use the CHLO packet size, not message size when determining how large a REJ can
be. Protected by --quic_use_chlo_packet_size

This should reduce number of round trips during the handshake slightly.

Merge internal change: 129160718

Rollback of internal changelist 128865569.

*** Original change description ***

Inline PacingSender into QuicSentPacketManager. Guarded by
gfe2_reloadable_flag_quic_use_inline_pacing.

***

Merge internal change: 129101660

Allow Debugging information to be added to Tracegraf via flag

This cl adds an optional debug_state field to TracegrafPackets, which
can be populated by arbitrary debugging strings.

This field will not be populated by default.  It will only be
populated when a developer manually flips the
gfe2_quic_tracegraf_debugging_state_enabled flag to true on a given
GFE.  Even then, the field will only be populated if the underlying
congestion-control algorithm's GetDebugState function returns a
non-empty string

Why is this useful?  This field is intended for debugging experimental
congestion-control algorithms (such as PCC) while they are still under
development.  It's tantamount to being able to add printfs to each
packet event while debugging the algorithm.  In such a case, its handy
to track the state of the algorithm along with each packet event.
Adding custom fields to TracegrafConnection for that purpose is
overkill.

LOG_STORAGE_INCREASE(GB/week): 0 GB / week
This field will only be populated during occasional debugging and WILL
ONLY BE OUTPUT TO A LOCAL LOGFILE.  I have added test cases that ensure
that this field is cleared before it is sent to logs storage as well as
the appropriate annotations in the log file.

Merge internal change: 129053230

Remove v33 connection id public flags hack as Maglev has rolled out. Protected
by quic_remove_v33_hacks.

Merge internal change: 129015386

Deprecate --quic_socket_walltimestamps

Merge internal change: 129001103

Deprecate quic_do_not_migrate_on_old_packet.

Merge internal change: 128998762

Flatten GeneralLossAlgorithm into QuicSentPacketManager. Not flag protected.

Also reorder GeneralLossAlgorithm per the class layout optimizer
recommendation.

REQUIRED_REVIEW=1

Merge internal change: 128997036

BUG=
==========

to

==========
Landing Recent QUIC changes until 4AM, Aug 7, 2016 UTC-4

Update quic flags.
https://codereview.chromium.org/2233943002/#ps40001

Removing obselete TODO
Merge internal change: 129550025
https://codereview.chromium.org/2228403004/#ps20001

Fix bug in QUIC force HOL blocking experiment, guarded by
--quic_enable_version_36_v2.
Make sure that new QUIC paramenter FHOL (force head of line blocking)
propagates to and from CHLO correctly.
Merge internal change: 129481622
https://codereview.chromium.org/2230223003/#ps20001

Refactor SendAlgorithmSimulator to accept arbitrary termination predicates
Also, correct the description of SendAlgorithmSimulator::TransferBytes() to
reflect its actual behavior.
n/a (test-only change)
Merge internal change: 129468670
https://codereview.chromium.org/2236533002/#ps20001

Adding a test utility to print QuicTagValueMaps.
Merge internal change: 129456177
https://codereview.chromium.org/2236513002/#ps20001

Rename QuicSupportedVersions to QuicAllSupportedVersions. Add
QuicCurrentSupportedVersions which returns filtered supported versions based on
flags. Not flag protected.
Merge internal change: 129440821
https://codereview.chromium.org/2236463004/#ps40001

Test only. Fix quic e2e test flakiness caused by quic_buffer_packet_till_chlo.
Add this flag into test argument permutation to avoid testing cheap
stateless reject without enabling buffering out of order packets.
Merge internal change: 129437595
https://codereview.chromium.org/2231463003/#ps20001

Introduce TTL in QuicReceivedPacket.
Merge internal change: 129363578
https://codereview.chromium.org/2229703003/#ps20001

Change use of std::tuple/std::get to testing::tuple/testing::get so that
parameterized test in quic_headers_stream_test.cc compiles not only for internal
and chromium, but also for the proto-quic environment.
n/a (Testing only.)
Merge internal change: 129359661
https://codereview.chromium.org/2233453002/#ps20001

Fix memory corruption from SetMaxPacingRate by inlining PacingSender.
This behavior can be disabled by setting
quic_disable_pacing_for_perf_tests to true.
Merge internal change: 129356268
https://codereview.chromium.org/2228783004/#ps20001

Track when QUIC connections are application limited. Protected by
quic_enable_app_limited_check.
This CL notifies the congestion control algorithm when the connection
has no outstanding data to send. No behavior change is expected.
Merge internal change: 129351671
https://codereview.chromium.org/2229023002/#ps20001

Make QuicDispatcher to queue packets for new connections while waiting for
CHLOs. Flag protected by --quic_buffer_packet_till_chlo
Merge internal change: 129327247
https://codereview.chromium.org/2222393002/#ps20001

QuicSession no longer directly owns its QuicConnection. Not flag protected.
Merge internal change: 129318081
https://codereview.chromium.org/2226643004/

Add VersionOfIndex() to quic_protocol.h
Merge internal change: 129226757
https://codereview.chromium.org/2220333003/

Increments --spdy_framer_use_new_methods2.
Avoid possible lifetime races by having SpdyDispatcher own the
HeadersHandler until all headers in the current block have been framed,
delaying the ownership transfer to the relevant DispatcherFdWrapper.
Increments spdy_framer_use_new_methods2 to spdy_framer_use_new_methods3.
Merge internal change: 129220409
https://codereview.chromium.org/2225153002/

Use the CHLO packet size, not message size when determining how large a REJ can
be. Protected by --quic_use_chlo_packet_size
This should reduce number of round trips during the handshake slightly.
Merge internal change: 129160718
https://codereview.chromium.org/2227553003/

Rollback of internal changelist 128865569.
*** Original change description ***
Inline PacingSender into QuicSentPacketManager. Guarded by
quic_use_inline_pacing.
***
Merge internal change: 129101660
https://codereview.chromium.org/2228613002/


Add GetDebugState() in SendAlgorithmInterface().
Merge internal change: 129053230
https://codereview.chromium.org/2222093002/

Remove v33 connection id public flags hack as Maglev has rolled out. Protected
by --quic_remove_v33_hacks.
Merge internal change: 129015386
https://codereview.chromium.org/2223993002/

Deprecate --quic_socket_walltimestamps
Merge internal change: 129001103
https://codereview.chromium.org/2229553003/

Deprecate --quic_do_not_migrate_on_old_packet.
Merge internal change: 128998762
https://codereview.chromium.org/2221093002/

Flatten GeneralLossAlgorithm into QuicSentPacketManager. Not flag protected.
Also reorder GeneralLossAlgorithm per the class layout optimizer
recommendation.
Merge internal change: 128997036
https://codereview.chromium.org/2223983002/

BUG=
==========

[danzh1, 2016-08-11 15:08:23]

The CQ bit was checked by danzh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 15:08:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danzh1, 2016-08-11 15:18:05]

Description was changed from

==========
Landing Recent QUIC changes until 4AM, Aug 7, 2016 UTC-4

Update quic flags.
https://codereview.chromium.org/2233943002/#ps40001

Removing obselete TODO
Merge internal change: 129550025
https://codereview.chromium.org/2228403004/#ps20001

Fix bug in QUIC force HOL blocking experiment, guarded by
--quic_enable_version_36_v2.
Make sure that new QUIC paramenter FHOL (force head of line blocking)
propagates to and from CHLO correctly.
Merge internal change: 129481622
https://codereview.chromium.org/2230223003/#ps20001

Refactor SendAlgorithmSimulator to accept arbitrary termination predicates
Also, correct the description of SendAlgorithmSimulator::TransferBytes() to
reflect its actual behavior.
n/a (test-only change)
Merge internal change: 129468670
https://codereview.chromium.org/2236533002/#ps20001

Adding a test utility to print QuicTagValueMaps.
Merge internal change: 129456177
https://codereview.chromium.org/2236513002/#ps20001

Rename QuicSupportedVersions to QuicAllSupportedVersions. Add
QuicCurrentSupportedVersions which returns filtered supported versions based on
flags. Not flag protected.
Merge internal change: 129440821
https://codereview.chromium.org/2236463004/#ps40001

Test only. Fix quic e2e test flakiness caused by quic_buffer_packet_till_chlo.
Add this flag into test argument permutation to avoid testing cheap
stateless reject without enabling buffering out of order packets.
Merge internal change: 129437595
https://codereview.chromium.org/2231463003/#ps20001

Introduce TTL in QuicReceivedPacket.
Merge internal change: 129363578
https://codereview.chromium.org/2229703003/#ps20001

Change use of std::tuple/std::get to testing::tuple/testing::get so that
parameterized test in quic_headers_stream_test.cc compiles not only for internal
and chromium, but also for the proto-quic environment.
n/a (Testing only.)
Merge internal change: 129359661
https://codereview.chromium.org/2233453002/#ps20001

Fix memory corruption from SetMaxPacingRate by inlining PacingSender.
This behavior can be disabled by setting
quic_disable_pacing_for_perf_tests to true.
Merge internal change: 129356268
https://codereview.chromium.org/2228783004/#ps20001

Track when QUIC connections are application limited. Protected by
quic_enable_app_limited_check.
This CL notifies the congestion control algorithm when the connection
has no outstanding data to send. No behavior change is expected.
Merge internal change: 129351671
https://codereview.chromium.org/2229023002/#ps20001

Make QuicDispatcher to queue packets for new connections while waiting for
CHLOs. Flag protected by --quic_buffer_packet_till_chlo
Merge internal change: 129327247
https://codereview.chromium.org/2222393002/#ps20001

QuicSession no longer directly owns its QuicConnection. Not flag protected.
Merge internal change: 129318081
https://codereview.chromium.org/2226643004/

Add VersionOfIndex() to quic_protocol.h
Merge internal change: 129226757
https://codereview.chromium.org/2220333003/

Increments --spdy_framer_use_new_methods2.
Avoid possible lifetime races by having SpdyDispatcher own the
HeadersHandler until all headers in the current block have been framed,
delaying the ownership transfer to the relevant DispatcherFdWrapper.
Increments spdy_framer_use_new_methods2 to spdy_framer_use_new_methods3.
Merge internal change: 129220409
https://codereview.chromium.org/2225153002/

Use the CHLO packet size, not message size when determining how large a REJ can
be. Protected by --quic_use_chlo_packet_size
This should reduce number of round trips during the handshake slightly.
Merge internal change: 129160718
https://codereview.chromium.org/2227553003/

Rollback of internal changelist 128865569.
*** Original change description ***
Inline PacingSender into QuicSentPacketManager. Guarded by
quic_use_inline_pacing.
***
Merge internal change: 129101660
https://codereview.chromium.org/2228613002/


Add GetDebugState() in SendAlgorithmInterface().
Merge internal change: 129053230
https://codereview.chromium.org/2222093002/

Remove v33 connection id public flags hack as Maglev has rolled out. Protected
by --quic_remove_v33_hacks.
Merge internal change: 129015386
https://codereview.chromium.org/2223993002/

Deprecate --quic_socket_walltimestamps
Merge internal change: 129001103
https://codereview.chromium.org/2229553003/

Deprecate --quic_do_not_migrate_on_old_packet.
Merge internal change: 128998762
https://codereview.chromium.org/2221093002/

Flatten GeneralLossAlgorithm into QuicSentPacketManager. Not flag protected.
Also reorder GeneralLossAlgorithm per the class layout optimizer
recommendation.
Merge internal change: 128997036
https://codereview.chromium.org/2223983002/

BUG=
==========

to

==========
Landing Recent QUIC changes until 4AM, Aug 7, 2016 UTC-4

Update quic flags.
https://codereview.chromium.org/2233943002/#ps40001

Removing obselete TODO
Merge internal change: 129550025
https://codereview.chromium.org/2228403004/#ps20001

Fix bug in QUIC force HOL blocking experiment, guarded by
--quic_enable_version_36_v2.
Make sure that new QUIC paramenter FHOL (force head of line blocking)
propagates to and from CHLO correctly.
Merge internal change: 129481622
https://codereview.chromium.org/2230223003/#ps20001

Refactor SendAlgorithmSimulator to accept arbitrary termination predicates
Also, correct the description of SendAlgorithmSimulator::TransferBytes() to
reflect its actual behavior.
n/a (test-only change)
Merge internal change: 129468670
https://codereview.chromium.org/2236533002/#ps20001

Adding a test utility to print QuicTagValueMaps.
Merge internal change: 129456177
https://codereview.chromium.org/2236513002/#ps20001

Rename QuicSupportedVersions to QuicAllSupportedVersions. Add
QuicCurrentSupportedVersions which returns filtered supported versions based on
flags. Not flag protected.
Merge internal change: 129440821
https://codereview.chromium.org/2236463004/#ps40001

Test only. Fix quic e2e test flakiness caused by quic_buffer_packet_till_chlo.
Add this flag into test argument permutation to avoid testing cheap
stateless reject without enabling buffering out of order packets.
Merge internal change: 129437595
https://codereview.chromium.org/2231463003/#ps20001

Introduce TTL in QuicReceivedPacket.
Merge internal change: 129363578
https://codereview.chromium.org/2229703003/#ps20001

Change use of std::tuple/std::get to testing::tuple/testing::get so that
parameterized test in quic_headers_stream_test.cc compiles not only for internal
and chromium, but also for the proto-quic environment.
n/a (Testing only.)
Merge internal change: 129359661
https://codereview.chromium.org/2233453002/#ps20001

Fix memory corruption from SetMaxPacingRate by inlining PacingSender.
This behavior can be disabled by setting
quic_disable_pacing_for_perf_tests to true.
Merge internal change: 129356268
https://codereview.chromium.org/2228783004/#ps20001

Track when QUIC connections are application limited. Protected by
quic_enable_app_limited_check.
This CL notifies the congestion control algorithm when the connection
has no outstanding data to send. No behavior change is expected.
Merge internal change: 129351671
https://codereview.chromium.org/2229023002/#ps20001

Make QuicDispatcher to queue packets for new connections while waiting for
CHLOs. Flag protected by --quic_buffer_packet_till_chlo
Merge internal change: 129327247
https://codereview.chromium.org/2222393002/#ps20001

QuicSession no longer directly owns its QuicConnection. Not flag protected.
Merge internal change: 129318081
https://codereview.chromium.org/2226643004/

Add VersionOfIndex() to quic_protocol.h
Merge internal change: 129226757
https://codereview.chromium.org/2220333003/

Increments spdy_framer_use_new_methods2 to spdy_framer_use_new_methods3.
Merge internal change: 129220409
https://codereview.chromium.org/2225153002/

Use the CHLO packet size, not message size when determining how large a REJ can
be. Protected by --quic_use_chlo_packet_size
This should reduce number of round trips during the handshake slightly.
Merge internal change: 129160718
https://codereview.chromium.org/2227553003/

Rollback of internal changelist 128865569.
*** Original change description ***
Inline PacingSender into QuicSentPacketManager. Guarded by
quic_use_inline_pacing.
***
Merge internal change: 129101660
https://codereview.chromium.org/2228613002/


Add GetDebugState() in SendAlgorithmInterface().
Merge internal change: 129053230
https://codereview.chromium.org/2222093002/

Remove v33 connection id public flags hack. Protected by
--quic_remove_v33_hacks.
Merge internal change: 129015386
https://codereview.chromium.org/2223993002/

Deprecate --quic_socket_walltimestamps
Merge internal change: 129001103
https://codereview.chromium.org/2229553003/

Deprecate --quic_do_not_migrate_on_old_packet.
Merge internal change: 128998762
https://codereview.chromium.org/2221093002/

Flatten GeneralLossAlgorithm into QuicSentPacketManager. Not flag protected.
Also reorder GeneralLossAlgorithm per the class layout optimizer
recommendation.
Merge internal change: 128997036
https://codereview.chromium.org/2223983002/

BUG=
==========

[danzh1, 2016-08-11 15:19:03]

danzh@chromium.org changed reviewers:
+ rch@chromium.org

[commit-bot: I haz the power, 2016-08-11 16:12:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 16:12:36]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2016-08-11 18:36:16]

looks good, modulo the flag

https://codereview.chromium.org/2236973002/diff/20001/net/quic/core/quic_flag...
File net/quic/core/quic_flags.cc (right):

https://codereview.chromium.org/2236973002/diff/20001/net/quic/core/quic_flag...
net/quic/core/quic_flags.cc:127: bool
FLAGS_quic_sequencer_buffer_retire_block_in_time = false;
let's keep this true.

(Also can you add a comment with a description)

[danzh1, 2016-08-11 19:11:12]

On 2016/08/11 18:36:16, Ryan Hamilton wrote:
> looks good, modulo the flag
> 
>
https://codereview.chromium.org/2236973002/diff/20001/net/quic/core/quic_flag...
> File net/quic/core/quic_flags.cc (right):
> 
>
https://codereview.chromium.org/2236973002/diff/20001/net/quic/core/quic_flag...
> net/quic/core/quic_flags.cc:127: bool
> FLAGS_quic_sequencer_buffer_retire_block_in_time = false;
> let's keep this true.
> 
> (Also can you add a comment with a description)

done

[Ryan Hamilton, 2016-08-11 19:46:55]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2016-08-11 19:46:56]

lgtm

[commit-bot: I haz the power, 2016-08-11 19:47:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 19:59:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 19:59:30]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[danzh1, 2016-08-11 20:08:59]

Description was changed from

==========
Landing Recent QUIC changes until 4AM, Aug 7, 2016 UTC-4

Update quic flags.
https://codereview.chromium.org/2233943002/#ps40001

Removing obselete TODO
Merge internal change: 129550025
https://codereview.chromium.org/2228403004/#ps20001

Fix bug in QUIC force HOL blocking experiment, guarded by
--quic_enable_version_36_v2.
Make sure that new QUIC paramenter FHOL (force head of line blocking)
propagates to and from CHLO correctly.
Merge internal change: 129481622
https://codereview.chromium.org/2230223003/#ps20001

Refactor SendAlgorithmSimulator to accept arbitrary termination predicates
Also, correct the description of SendAlgorithmSimulator::TransferBytes() to
reflect its actual behavior.
n/a (test-only change)
Merge internal change: 129468670
https://codereview.chromium.org/2236533002/#ps20001

Adding a test utility to print QuicTagValueMaps.
Merge internal change: 129456177
https://codereview.chromium.org/2236513002/#ps20001

Rename QuicSupportedVersions to QuicAllSupportedVersions. Add
QuicCurrentSupportedVersions which returns filtered supported versions based on
flags. Not flag protected.
Merge internal change: 129440821
https://codereview.chromium.org/2236463004/#ps40001

Test only. Fix quic e2e test flakiness caused by quic_buffer_packet_till_chlo.
Add this flag into test argument permutation to avoid testing cheap
stateless reject without enabling buffering out of order packets.
Merge internal change: 129437595
https://codereview.chromium.org/2231463003/#ps20001

Introduce TTL in QuicReceivedPacket.
Merge internal change: 129363578
https://codereview.chromium.org/2229703003/#ps20001

Change use of std::tuple/std::get to testing::tuple/testing::get so that
parameterized test in quic_headers_stream_test.cc compiles not only for internal
and chromium, but also for the proto-quic environment.
n/a (Testing only.)
Merge internal change: 129359661
https://codereview.chromium.org/2233453002/#ps20001

Fix memory corruption from SetMaxPacingRate by inlining PacingSender.
This behavior can be disabled by setting
quic_disable_pacing_for_perf_tests to true.
Merge internal change: 129356268
https://codereview.chromium.org/2228783004/#ps20001

Track when QUIC connections are application limited. Protected by
quic_enable_app_limited_check.
This CL notifies the congestion control algorithm when the connection
has no outstanding data to send. No behavior change is expected.
Merge internal change: 129351671
https://codereview.chromium.org/2229023002/#ps20001

Make QuicDispatcher to queue packets for new connections while waiting for
CHLOs. Flag protected by --quic_buffer_packet_till_chlo
Merge internal change: 129327247
https://codereview.chromium.org/2222393002/#ps20001

QuicSession no longer directly owns its QuicConnection. Not flag protected.
Merge internal change: 129318081
https://codereview.chromium.org/2226643004/

Add VersionOfIndex() to quic_protocol.h
Merge internal change: 129226757
https://codereview.chromium.org/2220333003/

Increments spdy_framer_use_new_methods2 to spdy_framer_use_new_methods3.
Merge internal change: 129220409
https://codereview.chromium.org/2225153002/

Use the CHLO packet size, not message size when determining how large a REJ can
be. Protected by --quic_use_chlo_packet_size
This should reduce number of round trips during the handshake slightly.
Merge internal change: 129160718
https://codereview.chromium.org/2227553003/

Rollback of internal changelist 128865569.
*** Original change description ***
Inline PacingSender into QuicSentPacketManager. Guarded by
quic_use_inline_pacing.
***
Merge internal change: 129101660
https://codereview.chromium.org/2228613002/


Add GetDebugState() in SendAlgorithmInterface().
Merge internal change: 129053230
https://codereview.chromium.org/2222093002/

Remove v33 connection id public flags hack. Protected by
--quic_remove_v33_hacks.
Merge internal change: 129015386
https://codereview.chromium.org/2223993002/

Deprecate --quic_socket_walltimestamps
Merge internal change: 129001103
https://codereview.chromium.org/2229553003/

Deprecate --quic_do_not_migrate_on_old_packet.
Merge internal change: 128998762
https://codereview.chromium.org/2221093002/

Flatten GeneralLossAlgorithm into QuicSentPacketManager. Not flag protected.
Also reorder GeneralLossAlgorithm per the class layout optimizer
recommendation.
Merge internal change: 128997036
https://codereview.chromium.org/2223983002/

BUG=
==========

to

==========
Landing Recent QUIC changes until 4AM, Aug 7, 2016 UTC-4

Update quic flags.
https://codereview.chromium.org/2233943002/#ps40001

Removing obselete TODO
Merge internal change: 129550025
https://codereview.chromium.org/2228403004/#ps20001

Fix bug in QUIC force HOL blocking experiment, guarded by
--quic_enable_version_36_v2.
Make sure that new QUIC paramenter FHOL (force head of line blocking)
propagates to and from CHLO correctly.
Merge internal change: 129481622
https://codereview.chromium.org/2230223003/#ps20001

Refactor SendAlgorithmSimulator to accept arbitrary termination predicates
Also, correct the description of SendAlgorithmSimulator::TransferBytes() to
reflect its actual behavior.
n/a (test-only change)
Merge internal change: 129468670
https://codereview.chromium.org/2236533002/#ps20001

Adding a test utility to print QuicTagValueMaps.
Merge internal change: 129456177
https://codereview.chromium.org/2236513002/#ps20001

Rename QuicSupportedVersions to QuicAllSupportedVersions. Add
QuicCurrentSupportedVersions which returns filtered supported versions based on
flags. Not flag protected.
Merge internal change: 129440821
https://codereview.chromium.org/2236463004/#ps40001

Test only. Fix quic e2e test flakiness caused by quic_buffer_packet_till_chlo.
Add this flag into test argument permutation to avoid testing cheap
stateless reject without enabling buffering out of order packets.
Merge internal change: 129437595
https://codereview.chromium.org/2231463003/#ps20001

Introduce TTL in QuicReceivedPacket.
Merge internal change: 129363578
https://codereview.chromium.org/2229703003/#ps20001

Change use of std::tuple/std::get to testing::tuple/testing::get so that
parameterized test in quic_headers_stream_test.cc compiles not only for internal
and chromium, but also for the proto-quic environment.
n/a (Testing only.)
Merge internal change: 129359661
https://codereview.chromium.org/2233453002/#ps20001

Fix memory corruption from SetMaxPacingRate by inlining PacingSender.
This behavior can be disabled by setting
quic_disable_pacing_for_perf_tests to true.
Merge internal change: 129356268
https://codereview.chromium.org/2228783004/#ps20001

Track when QUIC connections are application limited. Protected by
quic_enable_app_limited_check.
This CL notifies the congestion control algorithm when the connection
has no outstanding data to send. No behavior change is expected.
Merge internal change: 129351671
https://codereview.chromium.org/2229023002/#ps20001

Make QuicDispatcher to queue packets for new connections while waiting for
CHLOs. Flag protected by --quic_buffer_packet_till_chlo
Merge internal change: 129327247
https://codereview.chromium.org/2222393002/#ps20001

QuicSession no longer directly owns its QuicConnection. Not flag protected.
Merge internal change: 129318081
https://codereview.chromium.org/2226643004/

Add VersionOfIndex() to quic_protocol.h
Merge internal change: 129226757
https://codereview.chromium.org/2220333003/

Increments spdy_framer_use_new_methods2 to spdy_framer_use_new_methods3.
Merge internal change: 129220409
https://codereview.chromium.org/2225153002/

Use the CHLO packet size, not message size when determining how large a REJ can
be. Protected by --quic_use_chlo_packet_size
This should reduce number of round trips during the handshake slightly.
Merge internal change: 129160718
https://codereview.chromium.org/2227553003/

Rollback of internal changelist 128865569.
*** Original change description ***
Inline PacingSender into QuicSentPacketManager. Guarded by
quic_use_inline_pacing.
***
Merge internal change: 129101660
https://codereview.chromium.org/2228613002/


Add GetDebugState() in SendAlgorithmInterface().
Merge internal change: 129053230
https://codereview.chromium.org/2222093002/

Remove v33 connection id public flags hack. Protected by
--quic_remove_v33_hacks.
Merge internal change: 129015386
https://codereview.chromium.org/2223993002/

Deprecate --quic_socket_walltimestamps
Merge internal change: 129001103
https://codereview.chromium.org/2229553003/

Deprecate --quic_do_not_migrate_on_old_packet.
Merge internal change: 128998762
https://codereview.chromium.org/2221093002/

Flatten GeneralLossAlgorithm into QuicSentPacketManager. Not flag protected.
Also reorder GeneralLossAlgorithm per the class layout optimizer
recommendation.
Merge internal change: 128997036
https://codereview.chromium.org/2223983002/
==========

[danzh1, 2016-08-11 20:09:09]

The CQ bit was checked by danzh@chromium.org

[commit-bot: I haz the power, 2016-08-11 20:09:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 20:19:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 20:19:42]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[danzh1, 2016-08-11 20:24:29]

danzh@chromium.org changed reviewers:
+ xunjieli@chromium.org

[danzh1, 2016-08-11 20:28:57]

Helen, can you take a look at changes under components/cronet? Missing owner's
LGTM

[xunjieli, 2016-08-11 20:31:09]

On 2016/08/11 20:28:57, danzh1 wrote:
> Helen, can you take a look at changes under components/cronet? Missing owner's
> LGTM

cronet/* LGTM!

[danzh1, 2016-08-11 20:32:10]

On 2016/08/11 20:28:57, danzh1 wrote:
> Helen, can you take a look at changes under components/cronet? Missing owner's
> LGTM

Thanks!

[danzh1, 2016-08-11 20:32:21]

The CQ bit was checked by danzh@chromium.org

[commit-bot: I haz the power, 2016-08-11 20:33:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 23:34:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 23:34:19]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[danzh1, 2016-08-12 13:23:07]

The CQ bit was checked by danzh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 13:23:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 14:00:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 14:00:44]

Dry run: This issue passed the CQ dry run.

[danzh1, 2016-08-12 14:01:40]

The CQ bit was checked by danzh@chromium.org

[commit-bot: I haz the power, 2016-08-12 14:02:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 14:08:07]

Description was changed from

==========
Landing Recent QUIC changes until 4AM, Aug 7, 2016 UTC-4

Update quic flags.
https://codereview.chromium.org/2233943002/#ps40001

Removing obselete TODO
Merge internal change: 129550025
https://codereview.chromium.org/2228403004/#ps20001

Fix bug in QUIC force HOL blocking experiment, guarded by
--quic_enable_version_36_v2.
Make sure that new QUIC paramenter FHOL (force head of line blocking)
propagates to and from CHLO correctly.
Merge internal change: 129481622
https://codereview.chromium.org/2230223003/#ps20001

Refactor SendAlgorithmSimulator to accept arbitrary termination predicates
Also, correct the description of SendAlgorithmSimulator::TransferBytes() to
reflect its actual behavior.
n/a (test-only change)
Merge internal change: 129468670
https://codereview.chromium.org/2236533002/#ps20001

Adding a test utility to print QuicTagValueMaps.
Merge internal change: 129456177
https://codereview.chromium.org/2236513002/#ps20001

Rename QuicSupportedVersions to QuicAllSupportedVersions. Add
QuicCurrentSupportedVersions which returns filtered supported versions based on
flags. Not flag protected.
Merge internal change: 129440821
https://codereview.chromium.org/2236463004/#ps40001

Test only. Fix quic e2e test flakiness caused by quic_buffer_packet_till_chlo.
Add this flag into test argument permutation to avoid testing cheap
stateless reject without enabling buffering out of order packets.
Merge internal change: 129437595
https://codereview.chromium.org/2231463003/#ps20001

Introduce TTL in QuicReceivedPacket.
Merge internal change: 129363578
https://codereview.chromium.org/2229703003/#ps20001

Change use of std::tuple/std::get to testing::tuple/testing::get so that
parameterized test in quic_headers_stream_test.cc compiles not only for internal
and chromium, but also for the proto-quic environment.
n/a (Testing only.)
Merge internal change: 129359661
https://codereview.chromium.org/2233453002/#ps20001

Fix memory corruption from SetMaxPacingRate by inlining PacingSender.
This behavior can be disabled by setting
quic_disable_pacing_for_perf_tests to true.
Merge internal change: 129356268
https://codereview.chromium.org/2228783004/#ps20001

Track when QUIC connections are application limited. Protected by
quic_enable_app_limited_check.
This CL notifies the congestion control algorithm when the connection
has no outstanding data to send. No behavior change is expected.
Merge internal change: 129351671
https://codereview.chromium.org/2229023002/#ps20001

Make QuicDispatcher to queue packets for new connections while waiting for
CHLOs. Flag protected by --quic_buffer_packet_till_chlo
Merge internal change: 129327247
https://codereview.chromium.org/2222393002/#ps20001

QuicSession no longer directly owns its QuicConnection. Not flag protected.
Merge internal change: 129318081
https://codereview.chromium.org/2226643004/

Add VersionOfIndex() to quic_protocol.h
Merge internal change: 129226757
https://codereview.chromium.org/2220333003/

Increments spdy_framer_use_new_methods2 to spdy_framer_use_new_methods3.
Merge internal change: 129220409
https://codereview.chromium.org/2225153002/

Use the CHLO packet size, not message size when determining how large a REJ can
be. Protected by --quic_use_chlo_packet_size
This should reduce number of round trips during the handshake slightly.
Merge internal change: 129160718
https://codereview.chromium.org/2227553003/

Rollback of internal changelist 128865569.
*** Original change description ***
Inline PacingSender into QuicSentPacketManager. Guarded by
quic_use_inline_pacing.
***
Merge internal change: 129101660
https://codereview.chromium.org/2228613002/


Add GetDebugState() in SendAlgorithmInterface().
Merge internal change: 129053230
https://codereview.chromium.org/2222093002/

Remove v33 connection id public flags hack. Protected by
--quic_remove_v33_hacks.
Merge internal change: 129015386
https://codereview.chromium.org/2223993002/

Deprecate --quic_socket_walltimestamps
Merge internal change: 129001103
https://codereview.chromium.org/2229553003/

Deprecate --quic_do_not_migrate_on_old_packet.
Merge internal change: 128998762
https://codereview.chromium.org/2221093002/

Flatten GeneralLossAlgorithm into QuicSentPacketManager. Not flag protected.
Also reorder GeneralLossAlgorithm per the class layout optimizer
recommendation.
Merge internal change: 128997036
https://codereview.chromium.org/2223983002/
==========

to

==========
Landing Recent QUIC changes until 4AM, Aug 7, 2016 UTC-4

Update quic flags.
https://codereview.chromium.org/2233943002/#ps40001

Removing obselete TODO
Merge internal change: 129550025
https://codereview.chromium.org/2228403004/#ps20001

Fix bug in QUIC force HOL blocking experiment, guarded by
--quic_enable_version_36_v2.
Make sure that new QUIC paramenter FHOL (force head of line blocking)
propagates to and from CHLO correctly.
Merge internal change: 129481622
https://codereview.chromium.org/2230223003/#ps20001

Refactor SendAlgorithmSimulator to accept arbitrary termination predicates
Also, correct the description of SendAlgorithmSimulator::TransferBytes() to
reflect its actual behavior.
n/a (test-only change)
Merge internal change: 129468670
https://codereview.chromium.org/2236533002/#ps20001

Adding a test utility to print QuicTagValueMaps.
Merge internal change: 129456177
https://codereview.chromium.org/2236513002/#ps20001

Rename QuicSupportedVersions to QuicAllSupportedVersions. Add
QuicCurrentSupportedVersions which returns filtered supported versions based on
flags. Not flag protected.
Merge internal change: 129440821
https://codereview.chromium.org/2236463004/#ps40001

Test only. Fix quic e2e test flakiness caused by quic_buffer_packet_till_chlo.
Add this flag into test argument permutation to avoid testing cheap
stateless reject without enabling buffering out of order packets.
Merge internal change: 129437595
https://codereview.chromium.org/2231463003/#ps20001

Introduce TTL in QuicReceivedPacket.
Merge internal change: 129363578
https://codereview.chromium.org/2229703003/#ps20001

Change use of std::tuple/std::get to testing::tuple/testing::get so that
parameterized test in quic_headers_stream_test.cc compiles not only for internal
and chromium, but also for the proto-quic environment.
n/a (Testing only.)
Merge internal change: 129359661
https://codereview.chromium.org/2233453002/#ps20001

Fix memory corruption from SetMaxPacingRate by inlining PacingSender.
This behavior can be disabled by setting
quic_disable_pacing_for_perf_tests to true.
Merge internal change: 129356268
https://codereview.chromium.org/2228783004/#ps20001

Track when QUIC connections are application limited. Protected by
quic_enable_app_limited_check.
This CL notifies the congestion control algorithm when the connection
has no outstanding data to send. No behavior change is expected.
Merge internal change: 129351671
https://codereview.chromium.org/2229023002/#ps20001

Make QuicDispatcher to queue packets for new connections while waiting for
CHLOs. Flag protected by --quic_buffer_packet_till_chlo
Merge internal change: 129327247
https://codereview.chromium.org/2222393002/#ps20001

QuicSession no longer directly owns its QuicConnection. Not flag protected.
Merge internal change: 129318081
https://codereview.chromium.org/2226643004/

Add VersionOfIndex() to quic_protocol.h
Merge internal change: 129226757
https://codereview.chromium.org/2220333003/

Increments spdy_framer_use_new_methods2 to spdy_framer_use_new_methods3.
Merge internal change: 129220409
https://codereview.chromium.org/2225153002/

Use the CHLO packet size, not message size when determining how large a REJ can
be. Protected by --quic_use_chlo_packet_size
This should reduce number of round trips during the handshake slightly.
Merge internal change: 129160718
https://codereview.chromium.org/2227553003/

Rollback of internal changelist 128865569.
*** Original change description ***
Inline PacingSender into QuicSentPacketManager. Guarded by
quic_use_inline_pacing.
***
Merge internal change: 129101660
https://codereview.chromium.org/2228613002/


Add GetDebugState() in SendAlgorithmInterface().
Merge internal change: 129053230
https://codereview.chromium.org/2222093002/

Remove v33 connection id public flags hack. Protected by
--quic_remove_v33_hacks.
Merge internal change: 129015386
https://codereview.chromium.org/2223993002/

Deprecate --quic_socket_walltimestamps
Merge internal change: 129001103
https://codereview.chromium.org/2229553003/

Deprecate --quic_do_not_migrate_on_old_packet.
Merge internal change: 128998762
https://codereview.chromium.org/2221093002/

Flatten GeneralLossAlgorithm into QuicSentPacketManager. Not flag protected.
Also reorder GeneralLossAlgorithm per the class layout optimizer
recommendation.
Merge internal change: 128997036
https://codereview.chromium.org/2223983002/
==========

[commit-bot: I haz the power, 2016-08-12 14:08:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-12 14:09:29]

Description was changed from

==========
Landing Recent QUIC changes until 4AM, Aug 7, 2016 UTC-4

Update quic flags.
https://codereview.chromium.org/2233943002/#ps40001

Removing obselete TODO
Merge internal change: 129550025
https://codereview.chromium.org/2228403004/#ps20001

Fix bug in QUIC force HOL blocking experiment, guarded by
--quic_enable_version_36_v2.
Make sure that new QUIC paramenter FHOL (force head of line blocking)
propagates to and from CHLO correctly.
Merge internal change: 129481622
https://codereview.chromium.org/2230223003/#ps20001

Refactor SendAlgorithmSimulator to accept arbitrary termination predicates
Also, correct the description of SendAlgorithmSimulator::TransferBytes() to
reflect its actual behavior.
n/a (test-only change)
Merge internal change: 129468670
https://codereview.chromium.org/2236533002/#ps20001

Adding a test utility to print QuicTagValueMaps.
Merge internal change: 129456177
https://codereview.chromium.org/2236513002/#ps20001

Rename QuicSupportedVersions to QuicAllSupportedVersions. Add
QuicCurrentSupportedVersions which returns filtered supported versions based on
flags. Not flag protected.
Merge internal change: 129440821
https://codereview.chromium.org/2236463004/#ps40001

Test only. Fix quic e2e test flakiness caused by quic_buffer_packet_till_chlo.
Add this flag into test argument permutation to avoid testing cheap
stateless reject without enabling buffering out of order packets.
Merge internal change: 129437595
https://codereview.chromium.org/2231463003/#ps20001

Introduce TTL in QuicReceivedPacket.
Merge internal change: 129363578
https://codereview.chromium.org/2229703003/#ps20001

Change use of std::tuple/std::get to testing::tuple/testing::get so that
parameterized test in quic_headers_stream_test.cc compiles not only for internal
and chromium, but also for the proto-quic environment.
n/a (Testing only.)
Merge internal change: 129359661
https://codereview.chromium.org/2233453002/#ps20001

Fix memory corruption from SetMaxPacingRate by inlining PacingSender.
This behavior can be disabled by setting
quic_disable_pacing_for_perf_tests to true.
Merge internal change: 129356268
https://codereview.chromium.org/2228783004/#ps20001

Track when QUIC connections are application limited. Protected by
quic_enable_app_limited_check.
This CL notifies the congestion control algorithm when the connection
has no outstanding data to send. No behavior change is expected.
Merge internal change: 129351671
https://codereview.chromium.org/2229023002/#ps20001

Make QuicDispatcher to queue packets for new connections while waiting for
CHLOs. Flag protected by --quic_buffer_packet_till_chlo
Merge internal change: 129327247
https://codereview.chromium.org/2222393002/#ps20001

QuicSession no longer directly owns its QuicConnection. Not flag protected.
Merge internal change: 129318081
https://codereview.chromium.org/2226643004/

Add VersionOfIndex() to quic_protocol.h
Merge internal change: 129226757
https://codereview.chromium.org/2220333003/

Increments spdy_framer_use_new_methods2 to spdy_framer_use_new_methods3.
Merge internal change: 129220409
https://codereview.chromium.org/2225153002/

Use the CHLO packet size, not message size when determining how large a REJ can
be. Protected by --quic_use_chlo_packet_size
This should reduce number of round trips during the handshake slightly.
Merge internal change: 129160718
https://codereview.chromium.org/2227553003/

Rollback of internal changelist 128865569.
*** Original change description ***
Inline PacingSender into QuicSentPacketManager. Guarded by
quic_use_inline_pacing.
***
Merge internal change: 129101660
https://codereview.chromium.org/2228613002/


Add GetDebugState() in SendAlgorithmInterface().
Merge internal change: 129053230
https://codereview.chromium.org/2222093002/

Remove v33 connection id public flags hack. Protected by
--quic_remove_v33_hacks.
Merge internal change: 129015386
https://codereview.chromium.org/2223993002/

Deprecate --quic_socket_walltimestamps
Merge internal change: 129001103
https://codereview.chromium.org/2229553003/

Deprecate --quic_do_not_migrate_on_old_packet.
Merge internal change: 128998762
https://codereview.chromium.org/2221093002/

Flatten GeneralLossAlgorithm into QuicSentPacketManager. Not flag protected.
Also reorder GeneralLossAlgorithm per the class layout optimizer
recommendation.
Merge internal change: 128997036
https://codereview.chromium.org/2223983002/
==========

to

==========
Landing Recent QUIC changes until 4AM, Aug 7, 2016 UTC-4

Update quic flags.
https://codereview.chromium.org/2233943002/#ps40001

Removing obselete TODO
Merge internal change: 129550025
https://codereview.chromium.org/2228403004/#ps20001

Fix bug in QUIC force HOL blocking experiment, guarded by
--quic_enable_version_36_v2.
Make sure that new QUIC paramenter FHOL (force head of line blocking)
propagates to and from CHLO correctly.
Merge internal change: 129481622
https://codereview.chromium.org/2230223003/#ps20001

Refactor SendAlgorithmSimulator to accept arbitrary termination predicates
Also, correct the description of SendAlgorithmSimulator::TransferBytes() to
reflect its actual behavior.
n/a (test-only change)
Merge internal change: 129468670
https://codereview.chromium.org/2236533002/#ps20001

Adding a test utility to print QuicTagValueMaps.
Merge internal change: 129456177
https://codereview.chromium.org/2236513002/#ps20001

Rename QuicSupportedVersions to QuicAllSupportedVersions. Add
QuicCurrentSupportedVersions which returns filtered supported versions based on
flags. Not flag protected.
Merge internal change: 129440821
https://codereview.chromium.org/2236463004/#ps40001

Test only. Fix quic e2e test flakiness caused by quic_buffer_packet_till_chlo.
Add this flag into test argument permutation to avoid testing cheap
stateless reject without enabling buffering out of order packets.
Merge internal change: 129437595
https://codereview.chromium.org/2231463003/#ps20001

Introduce TTL in QuicReceivedPacket.
Merge internal change: 129363578
https://codereview.chromium.org/2229703003/#ps20001

Change use of std::tuple/std::get to testing::tuple/testing::get so that
parameterized test in quic_headers_stream_test.cc compiles not only for internal
and chromium, but also for the proto-quic environment.
n/a (Testing only.)
Merge internal change: 129359661
https://codereview.chromium.org/2233453002/#ps20001

Fix memory corruption from SetMaxPacingRate by inlining PacingSender.
This behavior can be disabled by setting
quic_disable_pacing_for_perf_tests to true.
Merge internal change: 129356268
https://codereview.chromium.org/2228783004/#ps20001

Track when QUIC connections are application limited. Protected by
quic_enable_app_limited_check.
This CL notifies the congestion control algorithm when the connection
has no outstanding data to send. No behavior change is expected.
Merge internal change: 129351671
https://codereview.chromium.org/2229023002/#ps20001

Make QuicDispatcher to queue packets for new connections while waiting for
CHLOs. Flag protected by --quic_buffer_packet_till_chlo
Merge internal change: 129327247
https://codereview.chromium.org/2222393002/#ps20001

QuicSession no longer directly owns its QuicConnection. Not flag protected.
Merge internal change: 129318081
https://codereview.chromium.org/2226643004/

Add VersionOfIndex() to quic_protocol.h
Merge internal change: 129226757
https://codereview.chromium.org/2220333003/

Increments spdy_framer_use_new_methods2 to spdy_framer_use_new_methods3.
Merge internal change: 129220409
https://codereview.chromium.org/2225153002/

Use the CHLO packet size, not message size when determining how large a REJ can
be. Protected by --quic_use_chlo_packet_size
This should reduce number of round trips during the handshake slightly.
Merge internal change: 129160718
https://codereview.chromium.org/2227553003/

Rollback of internal changelist 128865569.
*** Original change description ***
Inline PacingSender into QuicSentPacketManager. Guarded by
quic_use_inline_pacing.
***
Merge internal change: 129101660
https://codereview.chromium.org/2228613002/

Add GetDebugState() in SendAlgorithmInterface().
Merge internal change: 129053230
https://codereview.chromium.org/2222093002/

Remove v33 connection id public flags hack. Protected by
--quic_remove_v33_hacks.
Merge internal change: 129015386
https://codereview.chromium.org/2223993002/

Deprecate --quic_socket_walltimestamps
Merge internal change: 129001103
https://codereview.chromium.org/2229553003/

Deprecate --quic_do_not_migrate_on_old_packet.
Merge internal change: 128998762
https://codereview.chromium.org/2221093002/

Flatten GeneralLossAlgorithm into QuicSentPacketManager. Not flag protected.
Also reorder GeneralLossAlgorithm per the class layout optimizer
recommendation.
Merge internal change: 128997036
https://codereview.chromium.org/2223983002/

Committed: https://crrev.com/3134c2563efdae541721a494b267c24dfea155ca
Cr-Commit-Position: refs/heads/master@{#411638}
==========

[commit-bot: I haz the power, 2016-08-12 14:09:31]

Patchset 3 (id:??) landed as
https://crrev.com/3134c2563efdae541721a494b267c24dfea155ca
Cr-Commit-Position: refs/heads/master@{#411638}