Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: net/quic/core/quic_session.h

Issue 2236973002: Landing Recent QUIC changes until 4AM, Aug 7, 2016 UTC-4 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: flip quic_sequencer_buffer_retire_block_in_time to true Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_server_session_base_test.cc ('k') | net/quic/core/quic_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_session.h
diff --git a/net/quic/core/quic_session.h b/net/quic/core/quic_session.h
index a4da9f986bc2cd76c20edc2aa816f82cf3836622..2c93486a6e80b3c56a177b7a34567c2a1a5d975a 100644
--- a/net/quic/core/quic_session.h
+++ b/net/quic/core/quic_session.h
@@ -57,7 +57,7 @@ class NET_EXPORT_PRIVATE QuicSession : public QuicConnectionVisitorInterface {
HANDSHAKE_CONFIRMED,
};
- // Takes ownership of |connection|.
+ // Does not take ownership of |connection|.
QuicSession(QuicConnection* connection, const QuicConfig& config);
~QuicSession() override;
@@ -155,8 +155,8 @@ class NET_EXPORT_PRIVATE QuicSession : public QuicConnectionVisitorInterface {
// not yet been created.
bool IsClosedStream(QuicStreamId id);
- QuicConnection* connection() { return connection_.get(); }
- const QuicConnection* connection() const { return connection_.get(); }
+ QuicConnection* connection() { return connection_; }
+ const QuicConnection* connection() const { return connection_; }
size_t num_active_requests() const { return dynamic_stream_map_.size(); }
const IPEndPoint& peer_address() const { return connection_->peer_address(); }
QuicConnectionId connection_id() const {
@@ -352,7 +352,7 @@ class NET_EXPORT_PRIVATE QuicSession : public QuicConnectionVisitorInterface {
std::map<QuicStreamId, QuicStreamOffset>
locally_closed_streams_highest_offset_;
- std::unique_ptr<QuicConnection> connection_;
+ QuicConnection* connection_;
std::vector<ReliableQuicStream*> closed_streams_;
« no previous file with comments | « net/quic/core/quic_server_session_base_test.cc ('k') | net/quic/core/quic_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698