Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: net/quic/core/quic_framer_test.cc

Issue 2236973002: Landing Recent QUIC changes until 4AM, Aug 7, 2016 UTC-4 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: flip quic_sequencer_buffer_retire_block_in_time to true Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_framer.cc ('k') | net/quic/core/quic_headers_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_framer_test.cc
diff --git a/net/quic/core/quic_framer_test.cc b/net/quic/core/quic_framer_test.cc
index 205ea06b1dd198fd3954202bc7261181696e60dd..b5255a6f9ff4d6a92b39e38a0a6fb582985d3498 100644
--- a/net/quic/core/quic_framer_test.cc
+++ b/net/quic/core/quic_framer_test.cc
@@ -352,7 +352,7 @@ class QuicFramerTest : public ::testing::TestWithParam<QuicVersion> {
: encrypter_(new test::TestEncrypter()),
decrypter_(new test::TestDecrypter()),
start_(QuicTime::Zero() + QuicTime::Delta::FromMicroseconds(0x10)),
- framer_(QuicSupportedVersions(), start_, Perspective::IS_SERVER) {
+ framer_(AllSupportedVersions(), start_, Perspective::IS_SERVER) {
version_ = GetParam();
framer_.set_version(version_);
framer_.SetDecrypter(ENCRYPTION_NONE, decrypter_);
@@ -4824,7 +4824,8 @@ TEST_P(QuicFramerTest, BuildStreamFramePacketWithVersionFlag) {
unsigned char packet[] = {
// public flags (version, 8 byte connection_id)
static_cast<unsigned char>(
- framer_.version() > QUIC_VERSION_32 ? 0x3D : 0x3D),
+ (FLAGS_quic_remove_v33_hacks &&
+ framer_.version() > QUIC_VERSION_32) ? 0x39 : 0x3D),
// connection_id
0x10, 0x32, 0x54, 0x76, 0x98, 0xBA, 0xDC, 0xFE,
// version tag
@@ -4845,7 +4846,8 @@ TEST_P(QuicFramerTest, BuildStreamFramePacketWithVersionFlag) {
};
unsigned char packet_34[] = {
// public flags (version, 8 byte connection_id)
- 0x3D,
+ static_cast<unsigned char>(
+ FLAGS_quic_remove_v33_hacks ? 0x39 : 0x3D),
// connection_id
0x10, 0x32, 0x54, 0x76, 0x98, 0xBA, 0xDC, 0xFE,
// version tag
@@ -4977,7 +4979,8 @@ TEST_P(QuicFramerTest, BuildStreamFramePacketWithBothVersionAndMultipathFlag) {
unsigned char packet[] = {
// public flags (8 byte connection_id)
static_cast<unsigned char>(
- framer_.version() > QUIC_VERSION_32 ? 0x7D : 0x7D),
+ (FLAGS_quic_remove_v33_hacks &&
+ framer_.version() > QUIC_VERSION_32) ? 0x79 : 0x7D),
// connection_id
0x10, 0x32, 0x54, 0x76,
0x98, 0xBA, 0xDC, 0xFE,
@@ -5005,7 +5008,8 @@ TEST_P(QuicFramerTest, BuildStreamFramePacketWithBothVersionAndMultipathFlag) {
};
unsigned char packet_34[] = {
// public flags (8 byte connection_id)
- 0x7D,
+ static_cast<unsigned char>(
+ FLAGS_quic_remove_v33_hacks ? 0x79 : 0x7D),
// connection_id
0x10, 0x32, 0x54, 0x76,
0x98, 0xBA, 0xDC, 0xFE,
@@ -7135,7 +7139,7 @@ extern "C" {
// target function to be fuzzed by Dr. Fuzz
void QuicFramerFuzzFunc(unsigned char* data, size_t size) {
- QuicFramer framer(QuicSupportedVersions(), QuicTime::Zero(),
+ QuicFramer framer(AllSupportedVersions(), QuicTime::Zero(),
Perspective::IS_SERVER);
const char* const packet_bytes = reinterpret_cast<const char*>(data);
« no previous file with comments | « net/quic/core/quic_framer.cc ('k') | net/quic/core/quic_headers_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698