net/quic/core/quic_framer.cc - Issue 2236973002: Landing Recent QUIC changes until 4AM, Aug 7, 2016 UTC-4

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/core/quic_framer.cc

Issue 2236973002: Landing Recent QUIC changes until 4AM, Aug 7, 2016 UTC-4 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: flip quic_sequencer_buffer_retire_block_in_time to true Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/core/quic_framer.cc

diff --git a/net/quic/core/quic_framer.cc b/net/quic/core/quic_framer.cc

index 1dad3576946ccdb2ff2ed3ee3b9108bed4d838cd..8ad11c456d564762b07ddc6ad5afff0ee6c45960 100644

--- a/net/quic/core/quic_framer.cc

+++ b/net/quic/core/quic_framer.cc

@@ -721,8 +721,8 @@ bool QuicFramer::AppendPacketHeader(const QuicPacketHeader& header,

case PACKET_8BYTE_CONNECTION_ID:

if (quic_version_ > QUIC_VERSION_32) {

public_flags |= PACKET_PUBLIC_FLAGS_8BYTE_CONNECTION_ID;

- if (perspective_ == Perspective::IS_CLIENT) {

- // TODO(rch): Fix this when v33 flags are supported by middle boxes.

+ if (!FLAGS_quic_remove_v33_hacks &&

+ perspective_ == Perspective::IS_CLIENT) {

public_flags |= PACKET_PUBLIC_FLAGS_8BYTE_CONNECTION_ID_OLD;

}

« no previous file with comments | « net/quic/core/quic_flags.cc ('k') | net/quic/core/quic_framer_test.cc » ('j') | no next file with comments »