net/tools/quic/chlo_extractor.cc - Issue 2236973002: Landing Recent QUIC changes until 4AM, Aug 7, 2016 UTC-4

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/chlo_extractor.cc

Issue 2236973002: Landing Recent QUIC changes until 4AM, Aug 7, 2016 UTC-4 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: flip quic_sequencer_buffer_retire_block_in_time to true Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/quic/chlo_extractor.cc

diff --git a/net/tools/quic/chlo_extractor.cc b/net/tools/quic/chlo_extractor.cc

index 16972345f595b55458b9ba07e2b764bc7b5c452c..24c9ab0e589c1c0ce73e588f17d7ab06da6d4521 100644

--- a/net/tools/quic/chlo_extractor.cc

+++ b/net/tools/quic/chlo_extractor.cc

@@ -148,7 +148,9 @@ void ChloFramerVisitor::OnError(CryptoFramer* framer) {}

void ChloFramerVisitor::OnHandshakeMessage(

const CryptoHandshakeMessage& message) {

- delegate_->OnChlo(framer_->version(), connection_id_, message);

+ if (delegate_ != nullptr) {

+ delegate_->OnChlo(framer_->version(), connection_id_, message);

+ }

found_chlo_ = true;

}

« no previous file with comments | « net/quic/test_tools/simple_quic_framer.cc ('k') | net/tools/quic/chlo_extractor_test.cc » ('j') | no next file with comments »