Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2236493002: Revert of Create blurred RRect mask on GPU (rather than uploading it) (Closed)

Created:
4 years, 4 months ago by robertphillips
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Create blurred RRect mask on GPU (rather than uploading it) (patchset #4 id:60001 of https://codereview.chromium.org/2222083004/ ) Reason for revert: Erg - dumb bug Original issue's description: > Create blurred RRect mask on GPU (rather than uploading it) > > This CL doesn't try to resolve any of the larger issues. It just moves the computation of the blurred RRect to the gpu and sets up to start using vertex attributes for a nine patch draw (i.e., returning the texture coordinates) > > All blurred rrects using the "analytic" path will change slightly with this CL. > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222083004 > > Committed: https://skia.googlesource.com/skia/+/75ccdc77a70ec2083141bf9ba98eb2f01ece2479 TBR=bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/69cfa9c28dc847a813644c6a1f7ba034419601b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -198 lines) Patch
M include/core/SkMaskFilter.h View 2 chunks +1 line, -2 lines 0 comments Download
M include/effects/SkBlurMaskFilter.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 8 chunks +56 lines, -114 lines 0 comments Download
M src/effects/SkGpuBlurUtils.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice_drawTexture.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/BlurTest.cpp View 1 chunk +0 lines, -62 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
robertphillips
Created Revert of Create blurred RRect mask on GPU (rather than uploading it)
4 years, 4 months ago (2016-08-10 13:15:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236493002/1
4 years, 4 months ago (2016-08-10 13:15:27 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 13:15:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/69cfa9c28dc847a813644c6a1f7ba034419601b6

Powered by Google App Engine
This is Rietveld 408576698