[DevTools] Simplify evaluation callbacks on frontend

[DevTools] Simplify evaluation callbacks on frontend

BUG=635947
R=lushnikov@chromium.org

Committed: https://crrev.com/bf48b95307f9c3a066e4e3f882094bf577dfdab7
Cr-Commit-Position: refs/heads/master@{#411869}

[kozy, 2016-08-10 20:49:49]

Andrey, please take a look!

[lushnikov, 2016-08-11 00:55:45]

lgtm

https://codereview.chromium.org/2236033002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js (right):

https://codereview.chromium.org/2236033002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:98: return new
Promise((fulfill) => this.getOwnProperties((properties, internalProperties) =>
fulfill({ properties: properties, internalProperties: internalProperties })));
drop ()

lets' not nest arrow functions - looks funny!

https://codereview.chromium.org/2236033002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:163: return new
Promise((fulfill) => this.callFunction(functionDeclaration, args, (object,
wasThrown) => fulfill({ object: object, wasThrown: wasThrown })));
ditto

[kozy, 2016-08-13 00:11:37]

all done

https://codereview.chromium.org/2236033002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js (right):

https://codereview.chromium.org/2236033002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:98: return new
Promise((fulfill) => this.getOwnProperties((properties, internalProperties) =>
fulfill({ properties: properties, internalProperties: internalProperties })));
On 2016/08/11 00:55:44, lushnikov wrote:
> drop ()
> 
> lets' not nest arrow functions - looks funny!

Done.

https://codereview.chromium.org/2236033002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:163: return new
Promise((fulfill) => this.callFunction(functionDeclaration, args, (object,
wasThrown) => fulfill({ object: object, wasThrown: wasThrown })));
On 2016/08/11 00:55:44, lushnikov wrote:
> ditto

Done.

[kozy, 2016-08-13 00:11:40]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-08-13 00:11:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2236033002/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-08-13 00:12:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-13 03:25:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-13 03:27:40]

Description was changed from

==========
[DevTools] Simplify evaluation callbacks on frontend

BUG=635947
R=lushnikov@chromium.org
==========

to

==========
[DevTools] Simplify evaluation callbacks on frontend

BUG=635947
R=lushnikov@chromium.org

Committed: https://crrev.com/bf48b95307f9c3a066e4e3f882094bf577dfdab7
Cr-Commit-Position: refs/heads/master@{#411869}
==========

[commit-bot: I haz the power, 2016-08-13 03:27:41]

Patchset 2 (id:??) landed as
https://crrev.com/bf48b95307f9c3a066e4e3f882094bf577dfdab7
Cr-Commit-Position: refs/heads/master@{#411869}