third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js - Issue 2236033002: [DevTools] Simplify evaluation callbacks on frontend

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js

Issue 2236033002: [DevTools] Simplify evaluation callbacks on frontend (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-was-thrown

Patch Set: addressed comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js

index 0f353a4b04511025fbf60a4afa64e9c0b765adc5..988743d21f06c31aa303e91d7d07bd5eb247b6eb 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js

@@ -190,11 +190,9 @@ WebInspector.ConsoleModel.evaluateCommandInConsole = function(executionContext,

/**

* @param {?WebInspector.RemoteObject} result

- * @param {boolean} wasThrown

- * @param {?RuntimeAgent.RemoteObject=} valueResult

- * @param {?RuntimeAgent.ExceptionDetails=} exceptionDetails

+ * @param {!RuntimeAgent.ExceptionDetails=} exceptionDetails

- function printResult(result, wasThrown, valueResult, exceptionDetails)

+ function printResult(result, exceptionDetails)

{

if (!result)

return;

@@ -202,7 +200,7 @@ WebInspector.ConsoleModel.evaluateCommandInConsole = function(executionContext,

WebInspector.console.showPromise().then(reportUponEvaluation);

function reportUponEvaluation()

{

- target.consoleModel.dispatchEventToListeners(WebInspector.ConsoleModel.Events.CommandEvaluated, {result: result, wasThrown: wasThrown, text: requestedText, commandMessage: commandMessage, exceptionDetails: exceptionDetails});

+ target.consoleModel.dispatchEventToListeners(WebInspector.ConsoleModel.Events.CommandEvaluated, {result: result, text: requestedText, commandMessage: commandMessage, exceptionDetails: exceptionDetails});

}