Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2236033002: [DevTools] Simplify evaluation callbacks on frontend (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-was-thrown
Patch Set: addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
index e276bcd4640107b66bb371fc17fccbc6bceb18a0..aa7a8950f2d10d91ce84e3085de2bfc7ba9a45a2 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
@@ -978,12 +978,12 @@ WebInspector.SourcesPanel.prototype = {
if (!currentExecutionContext)
return;
- currentExecutionContext.globalObject("", false, false, didGetGlobalObject);
+ currentExecutionContext.globalObject("", false, didGetGlobalObject);
/**
* @param {?WebInspector.RemoteObject} global
- * @param {boolean=} wasThrown
+ * @param {!RuntimeAgent.ExceptionDetails=} exceptionDetails
*/
- function didGetGlobalObject(global, wasThrown)
+ function didGetGlobalObject(global, exceptionDetails)
{
/**
* @suppressReceiverCheck
@@ -1000,7 +1000,7 @@ WebInspector.SourcesPanel.prototype = {
return name;
}
- if (wasThrown || !global)
+ if (!!exceptionDetails || !global)
failedToSave(global);
else
global.callFunction(remoteFunction, [WebInspector.RemoteObject.toCallArgument(remoteObject)], didSave.bind(null, global));

Powered by Google App Engine
This is Rietveld 408576698