third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js - Issue 2236033002: [DevTools] Simplify evaluation callbacks on frontend

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

Issue 2236033002: [DevTools] Simplify evaluation callbacks on frontend (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-was-thrown

Patch Set: addressed comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

index ea7196f7f2058df148dc948772780f6032a82d80..760cf80bbc1aa215b2111c65356a0f5645acb92e 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

@@ -104,7 +104,7 @@ InspectorTest.evaluateFunctionInOverlay = function(func, callback)

var mainContext = InspectorTest.runtimeModel.executionContexts()[0];

mainContext.evaluate(expression, "", false, false, true, false, false, wrapCallback);

- function wrapCallback(val, err, result)

+ function wrapCallback(result, exceptionDetails)

{

callback(result.value)

}

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js » ('j') | no next file with comments »