Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 2236033002: [DevTools] Simplify evaluation callbacks on frontend (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-was-thrown
Patch Set: addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
index 1fb8b5f3ae151b03e50a05ef9dbeacdc97a3236a..d9f09fbe812fb4c202a7f7dcd3293c86756e0e62 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
@@ -583,10 +583,10 @@ WebInspector.JavaScriptSourceFrame.prototype = {
/**
* @param {?RuntimeAgent.RemoteObject} result
- * @param {boolean=} wasThrown
+ * @param {!RuntimeAgent.ExceptionDetails=} exceptionDetails
* @this {WebInspector.JavaScriptSourceFrame}
*/
- function showObjectPopover(result, wasThrown)
+ function showObjectPopover(result, exceptionDetails)
{
var target = WebInspector.context.flavor(WebInspector.Target);
if (selectedCallFrame.target() !== target || !debuggerModel.isPaused() || !result) {
@@ -594,7 +594,7 @@ WebInspector.JavaScriptSourceFrame.prototype = {
return;
}
this._popoverAnchorBox = anchorBox;
- showCallback(target.runtimeModel.createRemoteObject(result), wasThrown, this._popoverAnchorBox);
+ showCallback(target.runtimeModel.createRemoteObject(result), !!exceptionDetails, this._popoverAnchorBox);
// Popover may have been removed by showCallback().
if (this._popoverAnchorBox) {
var highlightRange = new WebInspector.TextRange(lineNumber, startHighlight, lineNumber, endHighlight);

Powered by Google App Engine
This is Rietveld 408576698