base: Do not allow MessagePumpObservers to consume events.

base: Do not allow MessagePumpObservers to consume events.

There is currently a single message-pump observer that can consume an event,
and it does so only when the num-lock key is pressed on Chrome OS. But it
doesn't need to consume the event, because no other dispatcher/observer cares
about this event. So remove a MessagePumpObserver's ability to consume an
event. This makes the code cleaner, and easier to understand.

BUG=354062
R=darin@chromium.org, derat@chromium.org, sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262019

[sadrul, 2014-04-03 08:22:53]

derat@ for chrome/browser/chromeos/ changes

darin@ for base/

sky@ for the rest

[Daniel Erat, 2014-04-03 14:11:59]

lgtm for c/b/chromeos

[sky, 2014-04-03 15:43:21]

LGTM

https://codereview.chromium.org/223483002/diff/1/base/message_loop/message_pu...
File base/message_loop/message_pump_x11.cc (right):

https://codereview.chromium.org/223483002/diff/1/base/message_loop/message_pu...
base/message_loop/message_pump_x11.cc:270:
FOR_EACH_OBSERVER(MessagePumpObserver, observers(), WillProcessEvent(xevent));
I would just inline this now.

[sadrul, 2014-04-03 16:22:49]

https://codereview.chromium.org/223483002/diff/1/base/message_loop/message_pu...
File base/message_loop/message_pump_x11.cc (right):

https://codereview.chromium.org/223483002/diff/1/base/message_loop/message_pu...
base/message_loop/message_pump_x11.cc:270:
FOR_EACH_OBSERVER(MessagePumpObserver, observers(), WillProcessEvent(xevent));
On 2014/04/03 15:43:21, sky wrote:
> I would just inline this now.

I have kept this in a separate function for now since for the short term, we
will need to call back into this from the event-source (see
https://codereview.chromium.org/219743002/diff/110001/ui/events/platform/x11/...).
Once we can remove that todo, we should be able to just remove this.

[sky, 2014-04-03 18:24:35]

Ok, fair enough.

On Thu, Apr 3, 2014 at 9:22 AM,  <sadrul@chromium.org> wrote:
>
>
https://codereview.chromium.org/223483002/diff/1/base/message_loop/message_pu...
> File base/message_loop/message_pump_x11.cc (right):
>
>
https://codereview.chromium.org/223483002/diff/1/base/message_loop/message_pu...
> base/message_loop/message_pump_x11.cc:270:
> FOR_EACH_OBSERVER(MessagePumpObserver, observers(),
> WillProcessEvent(xevent));
> On 2014/04/03 15:43:21, sky wrote:
>>
>> I would just inline this now.
>
>
> I have kept this in a separate function for now since for the short
> term, we will need to call back into this from the event-source (see
>
https://codereview.chromium.org/219743002/diff/110001/ui/events/platform/x11/...).
> Once we can remove that todo, we should be able to just remove this.
>
> https://codereview.chromium.org/223483002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[darin (slow to review), 2014-04-05 05:39:44]

LGTM

[sadrul, 2014-04-05 17:38:09]

Committed patchset #2 manually as r262019 (presubmit successful).