Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: ui/gl/gl_surface_glx.cc

Issue 223483002: base: Do not allow MessagePumpObservers to consume events. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tot-merge-r262009 Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/platform/x11/x11_event_source.cc ('k') | ui/views/test/ui_controls_factory_desktop_aurax11.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_surface_glx.cc
diff --git a/ui/gl/gl_surface_glx.cc b/ui/gl/gl_surface_glx.cc
index 17a481a4de3809988ce9025e80631242e7395fd4..76476945cddd50963bc9456762b960a9dc04bfa8 100644
--- a/ui/gl/gl_surface_glx.cc
+++ b/ui/gl/gl_surface_glx.cc
@@ -332,22 +332,20 @@ class XExposeEventForwarder : public base::MessagePumpObserver {
}
private:
- virtual base::EventStatus WillProcessEvent (
- const base::NativeEvent& xevent) OVERRIDE {
+ virtual void WillProcessEvent(const base::NativeEvent& xevent) OVERRIDE {
if (xevent->type != Expose)
- return base::EVENT_CONTINUE;
+ return;
WindowMap::const_iterator found = child_to_parent_map_.find(
xevent->xexpose.window);
if (found == child_to_parent_map_.end())
- return base::EVENT_CONTINUE;
+ return;
gfx::AcceleratedWidget target_window = found->second;
XEvent forwarded_event = *xevent;
forwarded_event.xexpose.window = target_window;
XSendEvent(g_display, target_window, False, ExposureMask,
&forwarded_event);
- return base::EVENT_CONTINUE;
}
virtual void DidProcessEvent(const base::NativeEvent& xevent) OVERRIDE {
}
« no previous file with comments | « ui/events/platform/x11/x11_event_source.cc ('k') | ui/views/test/ui_controls_factory_desktop_aurax11.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698