Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: chrome/browser/chromeos/events/system_key_event_listener.cc

Issue 223483002: base: Do not allow MessagePumpObservers to consume events. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tot-merge-r262009 Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/events/system_key_event_listener.cc
diff --git a/chrome/browser/chromeos/events/system_key_event_listener.cc b/chrome/browser/chromeos/events/system_key_event_listener.cc
index e7f81754ee1c83723e2d4f7fbae9159058872512..adb8fcdd9c3be8b5e68a584633b424fb2358db8d 100644
--- a/chrome/browser/chromeos/events/system_key_event_listener.cc
+++ b/chrome/browser/chromeos/events/system_key_event_listener.cc
@@ -76,15 +76,14 @@ void SystemKeyEventListener::Stop() {
stopped_ = true;
}
-base::EventStatus SystemKeyEventListener::WillProcessEvent(
- const base::NativeEvent& event) {
- return ProcessedXEvent(event) ? base::EVENT_HANDLED : base::EVENT_CONTINUE;
+void SystemKeyEventListener::WillProcessEvent(const base::NativeEvent& event) {
+ ProcessedXEvent(event);
}
void SystemKeyEventListener::DidProcessEvent(const base::NativeEvent& event) {
}
-bool SystemKeyEventListener::ProcessedXEvent(XEvent* xevent) {
+void SystemKeyEventListener::ProcessedXEvent(XEvent* xevent) {
input_method::InputMethodManager* input_method_manager =
input_method::InputMethodManager::Get();
@@ -97,10 +96,8 @@ bool SystemKeyEventListener::ProcessedXEvent(XEvent* xevent) {
// Force turning off Num Lock (crosbug.com/29169)
input_method_manager->GetXKeyboard()->DisableNumLock();
}
- return true;
}
}
- return false;
}
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698