Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2277)

Unified Diff: chrome/browser/jankometer_win.cc

Issue 223483002: base: Do not allow MessagePumpObservers to consume events. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tot-merge-r262009 Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/jankometer_win.cc
diff --git a/chrome/browser/jankometer_win.cc b/chrome/browser/jankometer_win.cc
index 2217133d85ac2324e1b574272a5504cf4bdf79b3..f449ff39095d2711f2e042bafe993374bf93b69e 100644
--- a/chrome/browser/jankometer_win.cc
+++ b/chrome/browser/jankometer_win.cc
@@ -298,10 +298,9 @@ class UIJankObserver : public base::RefCountedThreadSafe<UIJankObserver>,
helper_.EndProcessingTimers();
}
- virtual base::EventStatus WillProcessEvent(
- const base::NativeEvent& event) OVERRIDE {
+ virtual void WillProcessEvent(const base::NativeEvent& event) OVERRIDE {
if (!helper_.MessageWillBeMeasured())
- return base::EVENT_CONTINUE;
+ return;
// GetMessageTime returns a LONG (signed 32-bit) and GetTickCount returns
// a DWORD (unsigned 32-bit). They both wrap around when the time is longer
// than they can hold. I'm not sure if GetMessageTime wraps around to 0,
@@ -317,7 +316,6 @@ class UIJankObserver : public base::RefCountedThreadSafe<UIJankObserver>,
base::TimeDelta::FromMilliseconds(cur_time - cur_message_issue_time);
helper_.StartProcessingTimers(queueing_time);
- return base::EVENT_CONTINUE;
}
virtual void DidProcessEvent(const base::NativeEvent& event) OVERRIDE {

Powered by Google App Engine
This is Rietveld 408576698