Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: ui/events/platform/x11/x11_event_source.cc

Issue 223483002: base: Do not allow MessagePumpObservers to consume events. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tot-merge-r262009 Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/display/chromeos/x11/native_display_delegate_x11.cc ('k') | ui/gl/gl_surface_glx.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/platform/x11/x11_event_source.cc
diff --git a/ui/events/platform/x11/x11_event_source.cc b/ui/events/platform/x11/x11_event_source.cc
index c4d2f46d09b5360c98c5a6b9332c9b411f7bb5b0..71a3fb5a93f6eea5ce20a29d64d416eb55156a5e 100644
--- a/ui/events/platform/x11/x11_event_source.cc
+++ b/ui/events/platform/x11/x11_event_source.cc
@@ -196,11 +196,9 @@ uint32_t X11EventSource::DispatchEvent(XEvent* xevent) {
// TODO(sad): Remove this once all MessagePumpObservers are turned into
// PlatformEventObservers.
- uint32_t action = ui::POST_DISPATCH_NONE;
- if (!base::MessagePumpX11::Current()->WillProcessXEvent(xevent)) {
- action = PlatformEventSource::DispatchEvent(xevent);
- base::MessagePumpX11::Current()->DidProcessXEvent(xevent);
- }
+ base::MessagePumpX11::Current()->WillProcessXEvent(xevent);
+ uint32_t action = PlatformEventSource::DispatchEvent(xevent);
+ base::MessagePumpX11::Current()->DidProcessXEvent(xevent);
if (have_cookie)
XFreeEventData(xevent->xgeneric.display, &xevent->xcookie);
« no previous file with comments | « ui/display/chromeos/x11/native_display_delegate_x11.cc ('k') | ui/gl/gl_surface_glx.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698