Issue 2230283004: Moving AutoBisectApi.working_dir fallback logic to the property code.

Issue 2230283004: Moving AutoBisectApi.working_dir fallback logic to the property code. (Closed)

Created:
4 years, 4 months ago by RobertoCN

Modified:
4 years, 4 months ago

Reviewers:
sullivan, dtu, prasadv, Paweł Hajdan Jr.

CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@workingdir

Target Ref:
refs/heads/master

Project:
build

Visibility:
Public.

Moving AutoBisectApi.working_dir fallback logic to the property code. De-duplicating the code to increase readability. It is also worth noting that the only remaining use for this fallback is for the benefit of recipe simulation test. R=phajdan.jr@chromium.org,sullivan,prasadv@chromium.org,dtu@chromium.org BUG=636499 Committed: https://chromium.googlesource.com/chromium/tools/build/+/e5ff4c787090f81aa4b0dfb61895be009429e92a

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	scripts/slave/recipe_modules/auto_bisect/api.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	scripts/slave/recipe_modules/auto_bisect/bisector.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	scripts/slave/recipe_modules/auto_bisect/revision_state.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Depends on Patchset:

Total messages: 5 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230283004/1

4 years, 4 months ago (2016-08-10 22:59:12 UTC) #3

commit-bot: I haz the power

4 years, 4 months ago (2016-08-10 23:02:39 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/e5ff4c787090f81aa4b0...