scripts/slave/recipe_modules/auto_bisect/revision_state.py - Issue 2230283004: Moving AutoBisectApi.working_dir fallback logic to the property code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/auto_bisect/revision_state.py

Issue 2230283004: Moving AutoBisectApi.working_dir fallback logic to the property code. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@workingdir

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/auto_bisect/revision_state.py

diff --git a/scripts/slave/recipe_modules/auto_bisect/revision_state.py b/scripts/slave/recipe_modules/auto_bisect/revision_state.py

index d64d94ee5604fcda9fb1d7b2b5eb3f3a7abcbb48..79740df111b67218cb5e602907c9004daa06668f 100644

--- a/scripts/slave/recipe_modules/auto_bisect/revision_state.py

+++ b/scripts/slave/recipe_modules/auto_bisect/revision_state.py

@@ -156,7 +156,7 @@ class RevisionState(object):

if self.needs_patch: # pragma: no cover

return False

api = self.bisector.api

- working_dir = api.working_dir or api.m.path['slave_build']

+ working_dir = api.working_dir

cwd = working_dir.join(

depot_config.DEPOT_DEPS_NAME[self.depot_name]['src'])

name = 'Checking DEPS for ' + self.commit_hash

« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/bisector.py ('k') | no next file » | no next file with comments »