Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Side by Side Diff: scripts/slave/recipe_modules/auto_bisect/api.py

Issue 2230283004: Moving AutoBisectApi.working_dir fallback logic to the property code. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@workingdir
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/bisector.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """API for the bisect recipe module. 5 """API for the bisect recipe module.
6 6
7 This API is meant to enable the bisect recipe to bisect any chromium-supported 7 This API is meant to enable the bisect recipe to bisect any chromium-supported
8 platform for any test that can be run via buildbot, perf or otherwise. 8 platform for any test that can be run via buildbot, perf or otherwise.
9 """ 9 """
10 10
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 self.full_deploy_script = None 48 self.full_deploy_script = None
49 49
50 # Keep track of working directory (which contains the checkout). 50 # Keep track of working directory (which contains the checkout).
51 # None means "default value". 51 # None means "default value".
52 self._working_dir = None 52 self._working_dir = None
53 53
54 @property 54 @property
55 def working_dir(self): 55 def working_dir(self):
56 if not self._working_dir: 56 if not self._working_dir:
57 self._working_dir = self.m.chromium_tests.get_checkout_dir({}) 57 self._working_dir = self.m.chromium_tests.get_checkout_dir({})
58 return self._working_dir 58 return self._working_dir or self.m.path['slave_build']
59 59
60 def perform_bisect(self, **flags): 60 def perform_bisect(self, **flags):
61 return local_bisect.perform_bisect(self, **flags) 61 return local_bisect.perform_bisect(self, **flags)
62 62
63 def create_bisector(self, bisect_config_dict, dummy_mode=False, **flags): 63 def create_bisector(self, bisect_config_dict, dummy_mode=False, **flags):
64 """Passes the api and the config dictionary to the Bisector constructor. 64 """Passes the api and the config dictionary to the Bisector constructor.
65 65
66 For details about the keys in the bisect config dictionary go to: 66 For details about the keys in the bisect config dictionary go to:
67 http://chromium.org/developers/speed-infra/perf-try-bots-bisect-bots/config 67 http://chromium.org/developers/speed-infra/perf-try-bots-bisect-bots/config
68 68
(...skipping 342 matching lines...) Expand 10 before | Expand all | Expand 10 after
411 affected_files, update_step, self.bot_db) 411 affected_files, update_step, self.bot_db)
412 finally: 412 finally:
413 if api.chromium.c.TARGET_PLATFORM == 'android': 413 if api.chromium.c.TARGET_PLATFORM == 'android':
414 if self.internal_bisect: # pragma: no cover 414 if self.internal_bisect: # pragma: no cover
415 api.chromium_android.init_and_sync( 415 api.chromium_android.init_and_sync(
416 gclient_config=api.chromium_android.c.internal_dir_name, 416 gclient_config=api.chromium_android.c.internal_dir_name,
417 use_bot_update=True) 417 use_bot_update=True)
418 else: 418 else:
419 self.ensure_checkout() 419 self.ensure_checkout()
420 api.chromium_android.common_tests_final_steps() 420 api.chromium_android.common_tests_final_steps()
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/bisector.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698