Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issue 2225253003: Using the new convention for resolving the checkout directory. (Closed)

Created:
4 years, 4 months ago by RobertoCN
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Using the new convention for resolving the checkout directory. Hashing the DEPS change for incremental builds(while bisecting rolls) depends on being able to resolve the path where the checkout is. A recent change made it so that a property of the api (.working_dir) is used instead of always asking the path module for 'slave_build'. R=sullivan,prasadv@chromium.org,phajdan.jr@chromium.org BUG=632712 Committed: https://chromium.googlesource.com/chromium/tools/build/+/d752c0093621a75eb2bf22b03239e893492ba494

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M scripts/slave/recipe_modules/auto_bisect/bisector.py View 1 chunk +1 line, -1 line 1 comment Download

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
RobertoCN
4 years, 4 months ago (2016-08-09 19:23:05 UTC) #1
sullivan
lgtm https://codereview.chromium.org/2225253003/diff/1/scripts/slave/recipe_modules/auto_bisect/bisector.py File scripts/slave/recipe_modules/auto_bisect/bisector.py (right): https://codereview.chromium.org/2225253003/diff/1/scripts/slave/recipe_modules/auto_bisect/bisector.py#newcode351 scripts/slave/recipe_modules/auto_bisect/bisector.py:351: cwd = (self.api.working_dir or self.api.m.path['slave_build']).join( Please add a ...
4 years, 4 months ago (2016-08-09 19:27:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225253003/1
4 years, 4 months ago (2016-08-10 17:54:51 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 17:58:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/d752c0093621a75eb2bf...

Powered by Google App Engine
This is Rietveld 408576698