scripts/slave/recipe_modules/auto_bisect/api.py - Issue 2230283004: Moving AutoBisectApi.working_dir fallback logic to the property code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/auto_bisect/api.py

Issue 2230283004: Moving AutoBisectApi.working_dir fallback logic to the property code. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@workingdir

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/auto_bisect/api.py

diff --git a/scripts/slave/recipe_modules/auto_bisect/api.py b/scripts/slave/recipe_modules/auto_bisect/api.py

index 9216f213a300594303e4b17c259552704c705a18..aa025b7b0dc1761f40f089a8e0439187d10d2210 100644

--- a/scripts/slave/recipe_modules/auto_bisect/api.py

+++ b/scripts/slave/recipe_modules/auto_bisect/api.py

@@ -55,7 +55,7 @@ class AutoBisectApi(recipe_api.RecipeApi):

def working_dir(self):

if not self._working_dir:

self._working_dir = self.m.chromium_tests.get_checkout_dir({})

- return self._working_dir

+ return self._working_dir or self.m.path['slave_build']

def perform_bisect(self, **flags):

return local_bisect.perform_bisect(self, **flags)

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/bisector.py » ('j') | no next file with comments »