Clean up document-mode specific UI.

Clean up document-mode specific UI.

- showMenuButtonInOmnibox and hasVisibleViewsAfterUrlBarWhenUnfocused
  are now always false.

- FeatureUtilities.isDocumentMode is always false outside of
  migration and loading related code.

- shouldShowMenuButton is now always true.

- Tests no longer need any document mode conditionals.

BUG=612245
Committed: https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78
Cr-Commit-Position: refs/heads/master@{#411959}

[Peter Wen, 2016-08-10 16:08:28]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 16:08:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 16:13:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 16:13:05]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Peter Wen, 2016-08-10 16:53:06]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 16:53:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 18:03:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 18:03:52]

Dry run: This issue passed the CQ dry run.

[Peter Wen, 2016-08-11 20:48:45]

Description was changed from

==========
Clean up document-mode specific UI.

BUG=612245
==========

to

==========
Clean up document-mode specific UI.

- showMenuButtonInOmnibox and hasVisibleViewsAfterUrlBarWhenUnfocused
  are now always false.

- FeatureUtilities.isDocumentMode is always false outside of
  migration and loading related code.

- shouldShowMenuButton is now always true.

- Tests no longer need any document mode conditionals.

BUG=612245
==========

[Peter Wen, 2016-08-11 20:49:37]

wnwen@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Peter Wen, 2016-08-11 20:49:38]

🍵

[Peter Wen, 2016-08-11 21:31:09]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 21:31:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 22:37:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 22:37:44]

Dry run: This issue passed the CQ dry run.

[gone, 2016-08-12 21:11:54]

dfalcantara@chromium.org changed reviewers:
+ twellington@chromium.org

[gone, 2016-08-12 21:11:55]

+twellington for the app menu badge behavior

[Theresa, 2016-08-12 21:19:01]

https://chromiumcodereview.appspot.com/2229353003/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java
(left):

https://chromiumcodereview.appspot.com/2229353003/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java:359:
public void showAppMenuUpdateBadge(boolean animate) {
This is fine. Took me a minute to remember but there is some duplicate code
(that I decided was okay at the time since document mode was going away).
ToolbarPhone still has its logic to showAppMenuUpdateBadge() for the
non-document mode toolbar.

[gone, 2016-08-12 21:21:54]

lgtm

[Peter Wen, 2016-08-15 12:50:05]

The CQ bit was checked by wnwen@chromium.org

[commit-bot: I haz the power, 2016-08-15 12:50:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2016-08-15 12:50:39]

Thanks for the reviews! :)

[commit-bot: I haz the power, 2016-08-15 12:51:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 12:52:00]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Peter Wen, 2016-08-15 13:09:27]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2016-08-15 13:09:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2229353003/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-08-15 13:09:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 13:46:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-15 13:48:24]

Description was changed from

==========
Clean up document-mode specific UI.

- showMenuButtonInOmnibox and hasVisibleViewsAfterUrlBarWhenUnfocused
  are now always false.

- FeatureUtilities.isDocumentMode is always false outside of
  migration and loading related code.

- shouldShowMenuButton is now always true.

- Tests no longer need any document mode conditionals.

BUG=612245
==========

to

==========
Clean up document-mode specific UI.

- showMenuButtonInOmnibox and hasVisibleViewsAfterUrlBarWhenUnfocused
  are now always false.

- FeatureUtilities.isDocumentMode is always false outside of
  migration and loading related code.

- shouldShowMenuButton is now always true.

- Tests no longer need any document mode conditionals.

BUG=612245

Committed: https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78
Cr-Commit-Position: refs/heads/master@{#411959}
==========

[commit-bot: I haz the power, 2016-08-15 13:48:26]

Patchset 3 (id:??) landed as
https://crrev.com/d9e4e266162e7f49031beb67c2c087e19d370e78
Cr-Commit-Position: refs/heads/master@{#411959}