chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java - Issue 2229353003: Clean up document-mode specific UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

Issue 2229353003: Clean up document-mode specific UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

index e1e06c830792dac2691ec7e46469b35caaaeef7f..814eb957d2bb31b934307d2cf8ffd593d4ed3ac6 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

@@ -689,8 +689,7 @@ public class ToolbarManager implements ToolbarTabController, UrlFocusChangeListe

* @return The view that the pop up menu should be anchored to on the UI.

public View getMenuAnchor() {

- return mToolbar.shouldShowMenuButton() ? mToolbar.getMenuButtonWrapper()

- : mToolbar.getLocationBar().getMenuAnchor();

+ return mToolbar.getMenuButtonWrapper();

}

/**

@@ -1027,8 +1026,7 @@ public class ToolbarManager implements ToolbarTabController, UrlFocusChangeListe

updateReloadState(tabCrashed);

updateBookmarkButtonStatus();

- mToolbar.getMenuButtonWrapper().setVisibility(

- mToolbar.shouldShowMenuButton() ? View.VISIBLE : View.GONE);

+ mToolbar.getMenuButtonWrapper().setVisibility(View.VISIBLE);

}

private void updateBookmarkButtonStatus() {