Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: chrome/android/javatests/src/org/chromium/chrome/browser/PopupTest.java

Issue 2229353003: Clean up document-mode specific UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser; 5 package org.chromium.chrome.browser;
6 6
7 import android.os.Environment; 7 import android.os.Environment;
8 import android.test.suitebuilder.annotation.MediumTest; 8 import android.test.suitebuilder.annotation.MediumTest;
9 import android.text.TextUtils; 9 import android.text.TextUtils;
10 10
11 import org.chromium.base.ContextUtils;
12 import org.chromium.base.ThreadUtils; 11 import org.chromium.base.ThreadUtils;
13 import org.chromium.base.test.util.Feature; 12 import org.chromium.base.test.util.Feature;
14 import org.chromium.chrome.R; 13 import org.chromium.chrome.R;
15 import org.chromium.chrome.browser.infobar.InfoBar; 14 import org.chromium.chrome.browser.infobar.InfoBar;
16 import org.chromium.chrome.browser.infobar.InfoBarContainer; 15 import org.chromium.chrome.browser.infobar.InfoBarContainer;
17 import org.chromium.chrome.browser.tabmodel.TabModelSelector; 16 import org.chromium.chrome.browser.tabmodel.TabModelSelector;
18 import org.chromium.chrome.browser.util.FeatureUtilities;
19 import org.chromium.chrome.test.ChromeActivityTestCaseBase; 17 import org.chromium.chrome.test.ChromeActivityTestCaseBase;
20 import org.chromium.content.browser.test.util.Criteria; 18 import org.chromium.content.browser.test.util.Criteria;
21 import org.chromium.content.browser.test.util.CriteriaHelper; 19 import org.chromium.content.browser.test.util.CriteriaHelper;
22 import org.chromium.content.browser.test.util.TouchCommon; 20 import org.chromium.content.browser.test.util.TouchCommon;
23 import org.chromium.net.test.EmbeddedTestServer; 21 import org.chromium.net.test.EmbeddedTestServer;
24 22
25 import java.util.ArrayList; 23 import java.util.ArrayList;
26 import java.util.concurrent.Callable; 24 import java.util.concurrent.Callable;
27 25
28 /** 26 /**
29 * Tests whether popup windows appear. 27 * Tests whether popup windows appear.
30 * In document mode, this will end up spawning multiple Activities.
31 */ 28 */
32 public class PopupTest extends ChromeActivityTestCaseBase<ChromeActivity> { 29 public class PopupTest extends ChromeActivityTestCaseBase<ChromeActivity> {
33 private static final String POPUP_HTML_PATH = "/chrome/test/data/android/pop up_test.html"; 30 private static final String POPUP_HTML_PATH = "/chrome/test/data/android/pop up_test.html";
34 31
35 private String mPopupHtmlUrl; 32 private String mPopupHtmlUrl;
36 private EmbeddedTestServer mTestServer; 33 private EmbeddedTestServer mTestServer;
37 34
38 public PopupTest() { 35 public PopupTest() {
39 super(ChromeActivity.class); 36 super(ChromeActivity.class);
40 } 37 }
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 @Override 75 @Override
79 public Integer call() { 76 public Integer call() {
80 return getNumInfobarsShowing(); 77 return getNumInfobarsShowing();
81 } 78 }
82 })); 79 }));
83 } 80 }
84 81
85 @MediumTest 82 @MediumTest
86 @Feature({"Popup"}) 83 @Feature({"Popup"})
87 public void testPopupWindowsAppearWhenAllowed() throws Exception { 84 public void testPopupWindowsAppearWhenAllowed() throws Exception {
88 boolean isDocumentMode = 85 final TabModelSelector selector = getActivity().getTabModelSelector();
89 FeatureUtilities.isDocumentMode(ContextUtils.getApplicationConte xt());
90 final TabModelSelector selector = isDocumentMode
91 ? ChromeApplication.getDocumentTabModelSelector()
92 : getActivity().getTabModelSelector();
93 86
94 loadUrl(mPopupHtmlUrl); 87 loadUrl(mPopupHtmlUrl);
95 CriteriaHelper.pollUiThread(Criteria.equals(1, new Callable<Integer>() { 88 CriteriaHelper.pollUiThread(Criteria.equals(1, new Callable<Integer>() {
96 @Override 89 @Override
97 public Integer call() { 90 public Integer call() {
98 return getNumInfobarsShowing(); 91 return getNumInfobarsShowing();
99 } 92 }
100 })); 93 }));
101 assertEquals(1, selector.getTotalTabCount()); 94 assertEquals(1, selector.getTotalTabCount());
102 final InfoBarContainer container = selector.getCurrentTab().getInfoBarCo ntainer(); 95 final InfoBarContainer container = selector.getCurrentTab().getInfoBarCo ntainer();
(...skipping 29 matching lines...) Expand all
132 @Override 125 @Override
133 public boolean isSatisfied() { 126 public boolean isSatisfied() {
134 if (getNumInfobarsShowing() != 0) return false; 127 if (getNumInfobarsShowing() != 0) return false;
135 if (selector.getTotalTabCount() != 7) return false; 128 if (selector.getTotalTabCount() != 7) return false;
136 return TextUtils.equals("Popup #3", selector.getCurrentTab().get Title()); 129 return TextUtils.equals("Popup #3", selector.getCurrentTab().get Title());
137 } 130 }
138 }, 7500, CriteriaHelper.DEFAULT_POLLING_INTERVAL); 131 }, 7500, CriteriaHelper.DEFAULT_POLLING_INTERVAL);
139 assertNotSame(currentTabId, selector.getCurrentTab().getId()); 132 assertNotSame(currentTabId, selector.getCurrentTab().getId());
140 } 133 }
141 } 134 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698