chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java - Issue 2229353003: Clean up document-mode specific UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java

Issue 2229353003: Clean up document-mode specific UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/PopupTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java

index 97e3ee18e24944c42c4c22b13aca5287230d5f84..e6fea143b262e36f614cffef0cfc2bc2fdb1e864 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java

@@ -109,8 +109,7 @@ public class ToolbarTablet extends ToolbarLayout implements OnClickListener {

mBookmarkButton = (TintedImageButton) findViewById(R.id.bookmark_button);

mMenuButton = (TintedImageButton) findViewById(R.id.menu_button);

- mMenuButtonWrapper.setVisibility(

- shouldShowMenuButton() ? View.VISIBLE : View.GONE);

+ mMenuButtonWrapper.setVisibility(View.VISIBLE);

if (mAccessibilitySwitcherButton.getVisibility() == View.GONE

&& mMenuButtonWrapper.getVisibility() == View.GONE) {