chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java - Issue 2229353003: Clean up document-mode specific UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

Issue 2229353003: Clean up document-mode specific UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

index c99d98f24b48bb72ca3e6895a25bfef2885ab331..210dea89961b880d2d5a430be5ae824343617bc3 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

@@ -36,7 +36,6 @@ import org.chromium.chrome.browser.tabmodel.TabCreatorManager.TabCreator;

import org.chromium.chrome.browser.tabmodel.TabModel;

import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;

import org.chromium.chrome.browser.tabmodel.TabModelUtils;

-import org.chromium.chrome.browser.util.FeatureUtilities;

import org.chromium.components.web_contents_delegate_android.WebContentsDelegateAndroid;

import org.chromium.content_public.browser.InvalidateTypes;

import org.chromium.content_public.browser.WebContents;

@@ -83,11 +82,7 @@ public class TabWebContentsDelegateAndroid extends WebContentsDelegateAndroid {

// If the parent Tab belongs to another Activity, fire the Intent to bring it back.

if (isSelected && mTab.getParentIntent() != null

&& mTab.getActivity().getIntent() != mTab.getParentIntent()) {

- boolean mayLaunch = FeatureUtilities.isDocumentMode(mTab.getApplicationContext())

- ? isParentInAndroidOverview() : true;

- if (mayLaunch) {

- mTab.getActivity().startActivity(mTab.getParentIntent());

- }

+ mTab.getActivity().startActivity(mTab.getParentIntent());

}