4 years, 4 months ago
(2016-08-08 07:37:50 UTC)
#4
LGTM
commit-bot: I haz the power
Description was changed from ========== Revert of Move ThreadableLoader to Oilpan heap (2/3) (patchset #10 ...
4 years, 4 months ago
(2016-08-08 09:10:18 UTC)
#5
Message was sent while issue was closed.
Description was changed from
==========
Revert of Move ThreadableLoader to Oilpan heap (2/3) (patchset #10 id:400001 of
https://codereview.chromium.org/2181243002/ )
Reason for revert:
To investigate crashes reported at https://crbug.com/634546.
Original issue's description:
> Move ThreadableLoader to Oilpan heap (2/3)
>
> This change makes ThreadableLoader GarbageCollectedFinalized. Apart from
> trivial changes, this CL merges WorkerThreadableLoader,
> ThreadableLoaderClientWrapper and WorkerThreadableLoader::Bridge.
>
> BUG=587663
>
> Committed: https://crrev.com/82e485d87b1bd0f704e2e706db02203ea60801e5
> Cr-Commit-Position: refs/heads/master@{#409736}
TBR=haraken@chromium.org,japhet@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=587663
==========
to
==========
Revert of Move ThreadableLoader to Oilpan heap (2/3) (patchset #10 id:400001 of
https://codereview.chromium.org/2181243002/ )
Reason for revert:
To investigate crashes reported at https://crbug.com/634546.
Original issue's description:
> Move ThreadableLoader to Oilpan heap (2/3)
>
> This change makes ThreadableLoader GarbageCollectedFinalized. Apart from
> trivial changes, this CL merges WorkerThreadableLoader,
> ThreadableLoaderClientWrapper and WorkerThreadableLoader::Bridge.
>
> BUG=587663
>
> Committed: https://crrev.com/82e485d87b1bd0f704e2e706db02203ea60801e5
> Cr-Commit-Position: refs/heads/master@{#409736}
TBR=haraken@chromium.org,japhet@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=587663
==========
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago
(2016-08-08 09:10:19 UTC)
#6
Message was sent while issue was closed.
Committed patchset #1 (id:1)
commit-bot: I haz the power
Description was changed from ========== Revert of Move ThreadableLoader to Oilpan heap (2/3) (patchset #10 ...
4 years, 4 months ago
(2016-08-08 09:12:04 UTC)
#7
Message was sent while issue was closed.
Description was changed from
==========
Revert of Move ThreadableLoader to Oilpan heap (2/3) (patchset #10 id:400001 of
https://codereview.chromium.org/2181243002/ )
Reason for revert:
To investigate crashes reported at https://crbug.com/634546.
Original issue's description:
> Move ThreadableLoader to Oilpan heap (2/3)
>
> This change makes ThreadableLoader GarbageCollectedFinalized. Apart from
> trivial changes, this CL merges WorkerThreadableLoader,
> ThreadableLoaderClientWrapper and WorkerThreadableLoader::Bridge.
>
> BUG=587663
>
> Committed: https://crrev.com/82e485d87b1bd0f704e2e706db02203ea60801e5
> Cr-Commit-Position: refs/heads/master@{#409736}
TBR=haraken@chromium.org,japhet@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=587663
==========
to
==========
Revert of Move ThreadableLoader to Oilpan heap (2/3) (patchset #10 id:400001 of
https://codereview.chromium.org/2181243002/ )
Reason for revert:
To investigate crashes reported at https://crbug.com/634546.
Original issue's description:
> Move ThreadableLoader to Oilpan heap (2/3)
>
> This change makes ThreadableLoader GarbageCollectedFinalized. Apart from
> trivial changes, this CL merges WorkerThreadableLoader,
> ThreadableLoaderClientWrapper and WorkerThreadableLoader::Bridge.
>
> BUG=587663
>
> Committed: https://crrev.com/82e485d87b1bd0f704e2e706db02203ea60801e5
> Cr-Commit-Position: refs/heads/master@{#409736}
TBR=haraken@chromium.org,japhet@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=587663
Committed: https://crrev.com/af78c946a9616ef3c29addb3aecd835c20be7c05
Cr-Commit-Position: refs/heads/master@{#410321}
==========
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/af78c946a9616ef3c29addb3aecd835c20be7c05 Cr-Commit-Position: refs/heads/master@{#410321}
4 years, 4 months ago
(2016-08-08 09:12:06 UTC)
#8
Issue 2228433002: Revert of Move ThreadableLoader to Oilpan heap (2/3)
(Closed)
Created 4 years, 4 months ago by yhirano
Modified 4 years, 4 months ago
Reviewers: haraken, Nate Chapin
Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-bridge-peer-in-worker-threadable-loader
Comments: 0