Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2228433002: Revert of Move ThreadableLoader to Oilpan heap (2/3) (Closed)

Created:
4 years, 4 months ago by yhirano
Modified:
4 years, 4 months ago
Reviewers:
haraken, Nate Chapin
CC:
chromium-reviews, kinuko+worker_chromium.org, tyoshino+watch_chromium.org, dtapuska+blinkwatch_chromium.org, tzik, Peter Beverloo, eae+blinkwatch, nhiroki, yhirano+watch_chromium.org, falken, loading-reviews_chromium.org, dglazkov+blink, blink-reviews-events_chromium.org, gavinp+loader_chromium.org, blink-reviews, horo+watch_chromium.org, kinuko+watch, Nate Chapin, kinuko+fileapi, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@onheap-bridge-peer-in-worker-threadable-loader
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move ThreadableLoader to Oilpan heap (2/3) (patchset #10 id:400001 of https://codereview.chromium.org/2181243002/ ) Reason for revert: To investigate crashes reported at https://crbug.com/634546. Original issue's description: > Move ThreadableLoader to Oilpan heap (2/3) > > This change makes ThreadableLoader GarbageCollectedFinalized. Apart from > trivial changes, this CL merges WorkerThreadableLoader, > ThreadableLoaderClientWrapper and WorkerThreadableLoader::Bridge. > > BUG=587663 > > Committed: https://crrev.com/82e485d87b1bd0f704e2e706db02203ea60801e5 > Cr-Commit-Position: refs/heads/master@{#409736} TBR=haraken@chromium.org,japhet@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=587663 Committed: https://crrev.com/af78c946a9616ef3c29addb3aecd835c20be7c05 Cr-Commit-Position: refs/heads/master@{#410321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+495 lines, -329 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderLoader.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 36 chunks +55 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/loader/MockThreadableLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ThreadableLoader.h View 4 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ThreadableLoader.cpp View 1 chunk +4 lines, -1 line 0 comments Download
A third_party/WebKit/Source/core/loader/ThreadableLoaderClientWrapper.h View 1 chunk +158 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h View 4 chunks +48 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp View 6 chunks +137 lines, -191 lines 0 comments Download
M third_party/WebKit/Source/core/page/EventSource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/EventSource.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerScriptLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp View 8 chunks +55 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchManager.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationImageLoader.h View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/AssociatedURLLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/AssociatedURLLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
yhirano
Created Revert of Move ThreadableLoader to Oilpan heap (2/3)
4 years, 4 months ago (2016-08-08 07:37:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228433002/1
4 years, 4 months ago (2016-08-08 07:37:34 UTC) #3
haraken
LGTM
4 years, 4 months ago (2016-08-08 07:37:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 09:10:19 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 09:12:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af78c946a9616ef3c29addb3aecd835c20be7c05
Cr-Commit-Position: refs/heads/master@{#410321}

Powered by Google App Engine
This is Rietveld 408576698