third_party/WebKit/Source/modules/notifications/NotificationImageLoader.h - Issue 2228433002: Revert of Move ThreadableLoader to Oilpan heap (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationImageLoader.h

Issue 2228433002: Revert of Move ThreadableLoader to Oilpan heap (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-bridge-peer-in-worker-threadable-loader

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/FetchManager.cpp ('k') | third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationImageLoader.h

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.h b/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.h

index 59f488049c1e5daf03d0ea2293efad78394acbbb..363b4fb855e5fbf28409a786d5137dded208b362 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.h

+++ b/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.h

@@ -46,10 +46,7 @@

void didFail(const ResourceError&) override;

void didFailRedirectCheck() override;

- DEFINE_INLINE_TRACE()

- {

- visitor->trace(m_threadableLoader);

- }

+ DEFINE_INLINE_TRACE() {}

private:

void runCallbackWithEmptyBitmap();

@@ -58,7 +55,7 @@

double m_startTime;

RefPtr<SharedBuffer> m_data;

std::unique_ptr<ImageCallback> m_imageCallback;

- Member<ThreadableLoader> m_threadableLoader;

+ std::unique_ptr<ThreadableLoader> m_threadableLoader;

};

} // namespace blink