third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp - Issue 2228433002: Revert of Move ThreadableLoader to Oilpan heap (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

Issue 2228433002: Revert of Move ThreadableLoader to Oilpan heap (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-bridge-peer-in-worker-threadable-loader

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h ('k') | third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

diff --git a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

index 180c36ee91db4774dbd9781a09aa8989c1e862df..f84736aba6d9cfef720a23103388cd5ccb9abdce 100644

--- a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

+++ b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

@@ -1024,7 +1024,7 @@

// If, window.onload contains open() and send(), m_loader will be set to

// non 0 value. So, we cannot continue the outer open(). In such case,

// just abort the outer open() by returning false.

- ThreadableLoader* loader = m_loader.release();

+ std::unique_ptr<ThreadableLoader> loader = std::move(m_loader);

loader->cancel();

// If abort() called internalAbort() and a nested open() ended up

@@ -1705,7 +1705,6 @@

{

visitor->trace(m_responseBlob);

visitor->trace(m_responseLegacyStream);

- visitor->trace(m_loader);

visitor->trace(m_responseDocument);

visitor->trace(m_responseDocumentParser);

visitor->trace(m_responseArrayBuffer);