third_party/WebKit/Source/modules/fetch/FetchManager.cpp - Issue 2228433002: Revert of Move ThreadableLoader to Oilpan heap (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

Issue 2228433002: Revert of Move ThreadableLoader to Oilpan heap (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-bridge-peer-in-worker-threadable-loader

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp ('k') | third_party/WebKit/Source/modules/notifications/NotificationImageLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

index f8773e766a123a0970afb90b5997598cd1433226..0acdab59700c33ad0442203cb2f7cc1eeb594da2 100644

--- a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

+++ b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

@@ -169,7 +169,7 @@

Member<FetchManager> m_fetchManager;

Member<ScriptPromiseResolver> m_resolver;

Member<FetchRequestData> m_request;

- Member<ThreadableLoader> m_loader;

+ std::unique_ptr<ThreadableLoader> m_loader;

bool m_failed;

bool m_finished;

int m_responseHttpStatusCode;

@@ -204,7 +204,6 @@

visitor->trace(m_fetchManager);

visitor->trace(m_resolver);

visitor->trace(m_request);

- visitor->trace(m_loader);

visitor->trace(m_integrityVerifier);

visitor->trace(m_executionContext);

}

@@ -525,7 +524,7 @@

m_fetchManager = nullptr;

if (m_loader) {

m_loader->cancel();

- m_loader = nullptr;

+ m_loader.reset();

}

m_executionContext = nullptr;

}