third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp - Issue 2228433002: Revert of Move ThreadableLoader to Oilpan heap (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp

Issue 2228433002: Revert of Move ThreadableLoader to Oilpan heap (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-bridge-peer-in-worker-threadable-loader

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/ThreadableLoaderClientWrapper.h ('k') | third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp

diff --git a/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp b/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp

index 668a0045422d59985e70709ccdd6ad402927f4a9..d9e53d22194023fd5ea15f52a9f7c95eeb41daef 100644

--- a/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp

+++ b/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp

@@ -157,7 +157,7 @@

std::unique_ptr<DummyPageHolder> m_dummyPageHolder;

Checkpoint m_checkpoint;

- Persistent<DocumentThreadableLoader> m_loader;

+ std::unique_ptr<DocumentThreadableLoader> m_loader;

};

class WorkerThreadableLoaderTestHelper : public ThreadableLoaderTestHelper, public WorkerLoaderProxyProvider {

@@ -213,7 +213,7 @@

{

ASSERT(m_workerThread);

ASSERT(m_workerThread->isCurrentThread());

- m_loader = nullptr;

+ m_loader.reset();

}

Checkpoint& checkpoint() override

@@ -336,7 +336,7 @@

std::unique_ptr<DummyPageHolder> m_dummyPageHolder;

Checkpoint m_checkpoint;

// |m_loader| must be touched only from the worker thread only.

- CrossThreadPersistent<ThreadableLoader> m_loader;

+ std::unique_ptr<ThreadableLoader> m_loader;

};

class ThreadableLoaderTest : public ::testing::TestWithParam<ThreadableLoaderToTest> {