Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2226323002:
Resize DevTools target frames. (Closed)
|
Created:
4 years, 4 months ago by Eric Seckler Modified:
4 years, 4 months ago CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, darin-cc_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org, dgozman Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdds commands to get and set the frame size of a DevTools target.
This is a first step towards more flexible screenshots
(bit.ly/sized-screenshots): The size of the CompositorFrame sent from the
renderer and the screenshot size are determined by the size of the RWHV.
Combined with renderer-side Emulation overrides, this will allow us to obtain
screenshots of a configurable size.
We are planning on adding an additional Emulation override command that
allows us to scale and position the page content, which will enable
screenshots of a custom area of the page. Work-in-progress patch:
https://codereview.chromium.org/2237433004/
BUG=625577
Committed: https://crrev.com/10bf0b24f8656aa2046ad92ecda2d6fc78e8f7f7
Cr-Commit-Position: refs/heads/master@{#413721}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Rename, add tests, fix comments/style, add support in shell. #
Total comments: 6
Patch Set 3 : Don't expose WebContents through HeadlessWebContents. #
Total comments: 2
Patch Set 4 : move command to Emulation, pull out other fixes into separate patch. #
Total comments: 2
Patch Set 5 : No support for setFrameSize on Android. #
Total comments: 1
Patch Set 6 : Use MAYBE_ pattern to disable test on Android. #
Total comments: 4
Patch Set 7 : remove getFrameSize, rename to setVisibleSize. #
Total comments: 1
Messages
Total messages: 48 (24 generated)
skyostil@chromium.org changed reviewers: + skyostil@chromium.org
Seems to make sense from my point of view. https://codereview.chromium.org/2226323002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/inspector/browser_protocol.json (right): https://codereview.chromium.org/2226323002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/inspector/browser_protocol.json:4351: "name": "getWebContentsSize", Would get/setFrameSize or get/setMainFrameSize work in terms of naming? WebContents is sort of a weird internal thing. https://codereview.chromium.org/2226323002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/inspector/browser_protocol.json:4357: { "name": "width", "type": "integer", "description": "Web contents width." }, I'm guessing these are physical pixels -- still would be good to document it.
Patchset #2 (id:20001) has been deleted
Patchset #2 (id:40001) has been deleted
eseckler@chromium.org changed reviewers: + alexclarke@chromium.org
Sami + Alex, do you want to have another look before I send it out to Pavel? https://codereview.chromium.org/2226323002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/inspector/browser_protocol.json (right): https://codereview.chromium.org/2226323002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/inspector/browser_protocol.json:4351: "name": "getWebContentsSize", On 2016/08/09 16:45:44, Sami wrote: > Would get/setFrameSize or get/setMainFrameSize work in terms of naming? > WebContents is sort of a weird internal thing. Done. https://codereview.chromium.org/2226323002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/inspector/browser_protocol.json:4357: { "name": "width", "type": "integer", "description": "Web contents width." }, On 2016/08/09 16:45:44, Sami wrote: > I'm guessing these are physical pixels -- still would be good to document it. Actually, AFAICT, these are DIPs. Done.
Description was changed from ========== Resize WebContents via DevTools (chrome only for now). BUG= ========== to ========== Adds commands to get and set the frame size of a DevTools target. This is a first step towards more flexible screenshots (bit.ly/sized-screenshots): The size of the CompositorFrame sent from the renderer and the screenshot size are determined by the size of the RWHV. Combined with renderer-side Emulation overrides, this will allow us to obtain screenshots of a configurable size. (We are planning on adding an additional Emulation override command that allows us to scale and position the page content, which will enable screenshots of a custom area of the page.) BUG=625577 ==========
Description was changed from ========== Adds commands to get and set the frame size of a DevTools target. This is a first step towards more flexible screenshots (bit.ly/sized-screenshots): The size of the CompositorFrame sent from the renderer and the screenshot size are determined by the size of the RWHV. Combined with renderer-side Emulation overrides, this will allow us to obtain screenshots of a configurable size. (We are planning on adding an additional Emulation override command that allows us to scale and position the page content, which will enable screenshots of a custom area of the page.) BUG=625577 ========== to ========== Adds commands to get and set the frame size of a DevTools target. This is a first step towards more flexible screenshots (bit.ly/sized-screenshots): The size of the CompositorFrame sent from the renderer and the screenshot size are determined by the size of the RWHV. Combined with renderer-side Emulation overrides, this will allow us to obtain screenshots of a configurable size. (We are planning on adding an additional Emulation override command that allows us to scale and position the page content, which will enable screenshots of a custom area of the page.) BUG=625577 ==========
https://codereview.chromium.org/2226323002/diff/60001/headless/public/headles... File headless/public/headless_web_contents.h (right): https://codereview.chromium.org/2226323002/diff/60001/headless/public/headles... headless/public/headless_web_contents.h:65: virtual content::WebContents* GetWebContents() const = 0; Can we avoid exposing this? We don't want people accidentally depending on random parts of content.
https://codereview.chromium.org/2226323002/diff/60001/headless/public/headles... File headless/public/headless_web_contents.h (right): https://codereview.chromium.org/2226323002/diff/60001/headless/public/headles... headless/public/headless_web_contents.h:65: virtual content::WebContents* GetWebContents() const = 0; On 2016/08/10 12:11:40, Sami wrote: > Can we avoid exposing this? We don't want people accidentally depending on > random parts of content. Done.
lgtm. Thanks for adding the tests too.
https://codereview.chromium.org/2226323002/diff/60001/components/devtools_dis... File components/devtools_discovery/devtools_discovery_manager.cc (right): https://codereview.chromium.org/2226323002/diff/60001/components/devtools_dis... components/devtools_discovery/devtools_discovery_manager.cc:70: DevToolsDiscoveryManager::HandleCreateTargetCommand( Maybe mention in the patch comment that we don't need to change HeadlessDevToolsManagerDelegate::CreateTarget because that already supports width & height? https://codereview.chromium.org/2226323002/diff/60001/content/browser/devtool... File content/browser/devtools/protocol/devtools_protocol_browsertest.cc (right): https://codereview.chromium.org/2226323002/diff/60001/content/browser/devtool... content/browser/devtools/protocol/devtools_protocol_browsertest.cc:37: #define EXPECT_SIZE_EQ(expected, actual) \ Consider doing this instead: std::ostream& operator<<(std::ostream& os, gfx::Size s) { return os << s.ToString(); } Maybe that could live in ui/gfx/geometry/size.h?
Description was changed from ========== Adds commands to get and set the frame size of a DevTools target. This is a first step towards more flexible screenshots (bit.ly/sized-screenshots): The size of the CompositorFrame sent from the renderer and the screenshot size are determined by the size of the RWHV. Combined with renderer-side Emulation overrides, this will allow us to obtain screenshots of a configurable size. (We are planning on adding an additional Emulation override command that allows us to scale and position the page content, which will enable screenshots of a custom area of the page.) BUG=625577 ========== to ========== Adds commands to get and set the frame size of a DevTools target. This is a first step towards more flexible screenshots (bit.ly/sized-screenshots): The size of the CompositorFrame sent from the renderer and the screenshot size are determined by the size of the RWHV. Combined with renderer-side Emulation overrides, this will allow us to obtain screenshots of a configurable size. (We are planning on adding an additional Emulation override command that allows us to scale and position the page content, which will enable screenshots of a custom area of the page.) FYI, we don't need to change HeadlessDevToolsManagerDelegate::CreateTarget because it already supports the commands' width & height parameters. BUG=625577 ==========
Thanks! https://codereview.chromium.org/2226323002/diff/60001/components/devtools_dis... File components/devtools_discovery/devtools_discovery_manager.cc (right): https://codereview.chromium.org/2226323002/diff/60001/components/devtools_dis... components/devtools_discovery/devtools_discovery_manager.cc:70: DevToolsDiscoveryManager::HandleCreateTargetCommand( On 2016/08/10 12:39:48, alex clarke wrote: > Maybe mention in the patch comment that we don't need to change > HeadlessDevToolsManagerDelegate::CreateTarget because that already supports > width & height? Done. https://codereview.chromium.org/2226323002/diff/60001/content/browser/devtool... File content/browser/devtools/protocol/devtools_protocol_browsertest.cc (right): https://codereview.chromium.org/2226323002/diff/60001/content/browser/devtool... content/browser/devtools/protocol/devtools_protocol_browsertest.cc:37: #define EXPECT_SIZE_EQ(expected, actual) \ On 2016/08/10 12:39:48, alex clarke wrote: > Consider doing this instead: > > std::ostream& operator<<(std::ostream& os, gfx::Size s) { > return os << s.ToString(); > } > > Maybe that could live in ui/gfx/geometry/size.h? I like this better, since it avoids the conversion to string (and, in my opinion, produces nicer error messages). This helper is copied in various places around the code base at the moment. I agree, it should probably live somewhere where it can be reused. The most "central" place it currently lives is here in cc: cc/test/geometry_test_utils.h. Does it make sense to move it to ui/gfx, or can we depend on this file in cc?
Description was changed from ========== Adds commands to get and set the frame size of a DevTools target. This is a first step towards more flexible screenshots (bit.ly/sized-screenshots): The size of the CompositorFrame sent from the renderer and the screenshot size are determined by the size of the RWHV. Combined with renderer-side Emulation overrides, this will allow us to obtain screenshots of a configurable size. (We are planning on adding an additional Emulation override command that allows us to scale and position the page content, which will enable screenshots of a custom area of the page.) FYI, we don't need to change HeadlessDevToolsManagerDelegate::CreateTarget because it already supports the commands' width & height parameters. BUG=625577 ========== to ========== Adds commands to get and set the frame size of a DevTools target. This is a first step towards more flexible screenshots (bit.ly/sized-screenshots): The size of the CompositorFrame sent from the renderer and the screenshot size are determined by the size of the RWHV. Combined with renderer-side Emulation overrides, this will allow us to obtain screenshots of a configurable size. (We are planning on adding an additional Emulation override command that allows us to scale and position the page content, which will enable screenshots of a custom area of the page.) FYI, we don't need to change HeadlessDevToolsManagerDelegate::CreateTarget because it already supports the commands' width & height parameters. BUG=625577 ==========
eseckler@chromium.org changed reviewers: + pfeldman@chromium.org
+pfeldman (dgozman on cc) Hi Pavel, Sending this to you since you're familiar with the Browser domain. Thanks! Eric ========== Adds commands to get and set the frame size of a DevTools target. This is a first step towards more flexible screenshots (bit.ly/sized-screenshots): The size of the CompositorFrame sent from the renderer and the screenshot size are determined by the size of the RWHV. Combined with renderer-side Emulation overrides, this will allow us to obtain screenshots of a configurable size. (We are planning on adding an additional Emulation override command that allows us to scale and position the page content, which will enable screenshots of a custom area of the page.) FYI, we don't need to change HeadlessDevToolsManagerDelegate::CreateTarget because it already supports the commands' width & height parameters. BUG=625577 ==========
https://codereview.chromium.org/2226323002/diff/80001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/inspector/browser_protocol.json (right): https://codereview.chromium.org/2226323002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/browser_protocol.json:4363: "name": "setFrameSize", This should go through the emulation domain along the target connection.
Description was changed from ========== Adds commands to get and set the frame size of a DevTools target. This is a first step towards more flexible screenshots (bit.ly/sized-screenshots): The size of the CompositorFrame sent from the renderer and the screenshot size are determined by the size of the RWHV. Combined with renderer-side Emulation overrides, this will allow us to obtain screenshots of a configurable size. (We are planning on adding an additional Emulation override command that allows us to scale and position the page content, which will enable screenshots of a custom area of the page.) FYI, we don't need to change HeadlessDevToolsManagerDelegate::CreateTarget because it already supports the commands' width & height parameters. BUG=625577 ========== to ========== Adds commands to get and set the frame size of a DevTools target. This is a first step towards more flexible screenshots (bit.ly/sized-screenshots): The size of the CompositorFrame sent from the renderer and the screenshot size are determined by the size of the RWHV. Combined with renderer-side Emulation overrides, this will allow us to obtain screenshots of a configurable size. We are planning on adding an additional Emulation override command that allows us to scale and position the page content, which will enable screenshots of a custom area of the page. Work-in-progress patch: https://codereview.chromium.org/2237433004/ BUG=625577 ==========
Description was changed from ========== Adds commands to get and set the frame size of a DevTools target. This is a first step towards more flexible screenshots (bit.ly/sized-screenshots): The size of the CompositorFrame sent from the renderer and the screenshot size are determined by the size of the RWHV. Combined with renderer-side Emulation overrides, this will allow us to obtain screenshots of a configurable size. (We are planning on adding an additional Emulation override command that allows us to scale and position the page content, which will enable screenshots of a custom area of the page.) FYI, we don't need to change HeadlessDevToolsManagerDelegate::CreateTarget because it already supports the commands' width & height parameters. BUG=625577 ========== to ========== Adds commands to get and set the frame size of a DevTools target. This is a first step towards more flexible screenshots (bit.ly/sized-screenshots): The size of the CompositorFrame sent from the renderer and the screenshot size are determined by the size of the RWHV. Combined with renderer-side Emulation overrides, this will allow us to obtain screenshots of a configurable size. We are planning on adding an additional Emulation override command that allows us to scale and position the page content, which will enable screenshots of a custom area of the page. Work-in-progress patch: https://codereview.chromium.org/2237433004/ BUG=625577 ==========
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2226323002/diff/80001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/inspector/browser_protocol.json (right): https://codereview.chromium.org/2226323002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/browser_protocol.json:4363: "name": "setFrameSize", On 2016/08/11 00:39:58, pfeldman wrote: > This should go through the emulation domain along the target connection. Done. I'm leaving the width/height params for Browser.createTarget as headless-only feature, and have separated other fixes to createTarget/getTargets into a separate patch: https://codereview.chromium.org/2234343002/
https://codereview.chromium.org/2226323002/diff/100001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/inspector/browser_protocol.json (right): https://codereview.chromium.org/2226323002/diff/100001/third_party/WebKit/Sou... third_party/WebKit/Source/core/inspector/browser_protocol.json:761: "name": "getFrameSize", Do you expect getFrameSize to be used in automation? I was thinking that since we automate the page, we create it with given size and set size, we should be aware of it. So I would drop it.
https://codereview.chromium.org/2226323002/diff/100001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/inspector/browser_protocol.json (right): https://codereview.chromium.org/2226323002/diff/100001/third_party/WebKit/Sou... third_party/WebKit/Source/core/inspector/browser_protocol.json:761: "name": "getFrameSize", On 2016/08/11 14:34:17, pfeldman wrote: > Do you expect getFrameSize to be used in automation? I was thinking that since > we automate the page, we create it with given size and set size, we should be > aware of it. So I would drop it. It would allow us to take partial screenshots without prior knowledge of the current frame size. I think it'd be primarily useful in non-headless environments, but also in cases where the page can change the browser window size via window.resizeTo(). I'm thinking of its use in this way: - Get current frame size. - Put device metrics override in place with obtained frame size (so that setFrameSize doesn't affect page layout). - Set frame size, which resizes the RWHV to screenshot size. - Take screenshot. But since it's not necessary for the common use cases in headless, I'm happy to remove it if you think it's not useful.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
FYI, RWHV does not support resizing on Android via setSize() and it seems infeasible to support it in a different way. I've disabled the test for Android and added a comment that setFrameSize is not supported on Android. See here for related comment in RWHV: https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_wid...
Pavel and Dmitry, I've added a test that demonstrates the use of the commands in this patch and the visual transform patch (https://codereview.chromium.org/2237433004/) to take a screenshot of a specific area of the page here: https://codereview.chromium.org/2254923002/ (see devtools_protocol_browsertest.cc). PTAL and let me know if there's anything you'd like to talk about. Thank you! :)
Non-owner lgtm. https://codereview.chromium.org/2226323002/diff/120001/content/browser/devtoo... File content/browser/devtools/protocol/devtools_protocol_browsertest.cc (right): https://codereview.chromium.org/2226323002/diff/120001/content/browser/devtoo... content/browser/devtools/protocol/devtools_protocol_browsertest.cc:857: #if !defined(OS_ANDROID) nit: Please use the MAYBE_ pattern[1] to disable tests on some platforms so they are still compiled on all platforms. [1] e.g., https://cs.chromium.org/chromium/src/ui/gfx/font_unittest.cc?rcl=0&l=130
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
dgozman@chromium.org changed reviewers: + dgozman@chromium.org
https://codereview.chromium.org/2226323002/diff/140001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/inspector/browser_protocol.json (right): https://codereview.chromium.org/2226323002/diff/140001/third_party/WebKit/Sou... third_party/WebKit/Source/core/inspector/browser_protocol.json:761: "name": "getFrameSize", As you discussed with Pavel, let's remove this and only expose when we need it (but I think we won't really need it with current scenarios). https://codereview.chromium.org/2226323002/diff/140001/third_party/WebKit/Sou... third_party/WebKit/Source/core/inspector/browser_protocol.json:770: "name": "setFrameSize", I'm worried this name is confusing as a part of protocol. We operate Frames meaning iframes. Let's rename to setVisibleSize?
https://codereview.chromium.org/2226323002/diff/140001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/inspector/browser_protocol.json (right): https://codereview.chromium.org/2226323002/diff/140001/third_party/WebKit/Sou... third_party/WebKit/Source/core/inspector/browser_protocol.json:770: "name": "setFrameSize", On 2016/08/18 20:16:25, dgozman wrote: > I'm worried this name is confusing as a part of protocol. We operate Frames > meaning iframes. Let's rename to setVisibleSize? I'd find it clearer if the command's name actually reflects which component's size we're talking about. It's the RenderWidget, not sure what it's "public" name would be. Maybe setViewportSize? Though that may be confused with the visual viewport? (Same goes for setVisibleSize btw.)
https://codereview.chromium.org/2226323002/diff/140001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/inspector/browser_protocol.json (right): https://codereview.chromium.org/2226323002/diff/140001/third_party/WebKit/Sou... third_party/WebKit/Source/core/inspector/browser_protocol.json:770: "name": "setFrameSize", On 2016/08/18 22:04:40, Eric Seckler wrote: > On 2016/08/18 20:16:25, dgozman wrote: > > I'm worried this name is confusing as a part of protocol. We operate Frames > > meaning iframes. Let's rename to setVisibleSize? > > I'd find it clearer if the command's name actually reflects which component's > size we're talking about. It's the RenderWidget, not sure what it's "public" > name would be. Maybe setViewportSize? Though that may be confused with the > visual viewport? (Same goes for setVisibleSize btw.) I personally like setVisibleSize more, because it does not refer to any common name (like frame, viewport, etc).
Dmitry, Sami, PTAL :) On 2016/08/19 17:52:30, dgozman wrote: > https://codereview.chromium.org/2226323002/diff/140001/third_party/WebKit/Sou... > File third_party/WebKit/Source/core/inspector/browser_protocol.json (right): > > https://codereview.chromium.org/2226323002/diff/140001/third_party/WebKit/Sou... > third_party/WebKit/Source/core/inspector/browser_protocol.json:770: "name": > "setFrameSize", > On 2016/08/18 22:04:40, Eric Seckler wrote: > > On 2016/08/18 20:16:25, dgozman wrote: > > > I'm worried this name is confusing as a part of protocol. We operate Frames > > > meaning iframes. Let's rename to setVisibleSize? > > > > I'd find it clearer if the command's name actually reflects which component's > > size we're talking about. It's the RenderWidget, not sure what it's "public" > > name would be. Maybe setViewportSize? Though that may be confused with the > > visual viewport? (Same goes for setVisibleSize btw.) > > I personally like setVisibleSize more, because it does not refer to any common > name (like frame, viewport, etc). Renamed to setVisibleSize and removed getFrameSize.
Looks good to me. https://codereview.chromium.org/2226323002/diff/160001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/inspector/browser_protocol.json (right): https://codereview.chromium.org/2226323002/diff/160001/third_party/WebKit/Sou... third_party/WebKit/Source/core/inspector/browser_protocol.json:764: { "name": "width", "type": "integer", "description": "Frame width (DIP)." }, nit: Visible width/height instead of frame width/height?
lgtm
The CQ bit was checked by eseckler@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from skyostil@chromium.org Link to the patchset: https://codereview.chromium.org/2226323002/#ps160001 (title: "remove getFrameSize, rename to setVisibleSize.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Adds commands to get and set the frame size of a DevTools target. This is a first step towards more flexible screenshots (bit.ly/sized-screenshots): The size of the CompositorFrame sent from the renderer and the screenshot size are determined by the size of the RWHV. Combined with renderer-side Emulation overrides, this will allow us to obtain screenshots of a configurable size. We are planning on adding an additional Emulation override command that allows us to scale and position the page content, which will enable screenshots of a custom area of the page. Work-in-progress patch: https://codereview.chromium.org/2237433004/ BUG=625577 ========== to ========== Adds commands to get and set the frame size of a DevTools target. This is a first step towards more flexible screenshots (bit.ly/sized-screenshots): The size of the CompositorFrame sent from the renderer and the screenshot size are determined by the size of the RWHV. Combined with renderer-side Emulation overrides, this will allow us to obtain screenshots of a configurable size. We are planning on adding an additional Emulation override command that allows us to scale and position the page content, which will enable screenshots of a custom area of the page. Work-in-progress patch: https://codereview.chromium.org/2237433004/ BUG=625577 ==========
Message was sent while issue was closed.
Committed patchset #7 (id:160001)
Message was sent while issue was closed.
Description was changed from ========== Adds commands to get and set the frame size of a DevTools target. This is a first step towards more flexible screenshots (bit.ly/sized-screenshots): The size of the CompositorFrame sent from the renderer and the screenshot size are determined by the size of the RWHV. Combined with renderer-side Emulation overrides, this will allow us to obtain screenshots of a configurable size. We are planning on adding an additional Emulation override command that allows us to scale and position the page content, which will enable screenshots of a custom area of the page. Work-in-progress patch: https://codereview.chromium.org/2237433004/ BUG=625577 ========== to ========== Adds commands to get and set the frame size of a DevTools target. This is a first step towards more flexible screenshots (bit.ly/sized-screenshots): The size of the CompositorFrame sent from the renderer and the screenshot size are determined by the size of the RWHV. Combined with renderer-side Emulation overrides, this will allow us to obtain screenshots of a configurable size. We are planning on adding an additional Emulation override command that allows us to scale and position the page content, which will enable screenshots of a custom area of the page. Work-in-progress patch: https://codereview.chromium.org/2237433004/ BUG=625577 Committed: https://crrev.com/10bf0b24f8656aa2046ad92ecda2d6fc78e8f7f7 Cr-Commit-Position: refs/heads/master@{#413721} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/10bf0b24f8656aa2046ad92ecda2d6fc78e8f7f7 Cr-Commit-Position: refs/heads/master@{#413721} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
