Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2254923002:
Adds a test for screenshot area capturing. (Closed)
|
Created:
4 years, 4 months ago by Eric Seckler Modified:
4 years, 3 months ago CC:
chromium-reviews, mlamouri+watch-content_chromium.org, caseq+blink_chromium.org, Peter Beverloo, jam, piman+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, pfeldman+blink_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, kalyank, danakj+watch_chromium.org, apavlov+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org, Sami Base URL:
https://chromium.googlesource.com/chromium/src.git@eseckler_compositoroverrides Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdds a test for screenshot area capturing.
Based on https://codereview.chromium.org/2237433004/, which adds the required forceViewport DevTools command.
Also refactors the original screenshot test and re-enables it for Android.
BUG=625577
Committed: https://crrev.com/503266cd434ea508d17e6698c15da481b42ab095
Cr-Commit-Position: refs/heads/master@{#420317}
Patch Set 1 #Patch Set 2 : use MAYBE_ pattern to disable tests on Android. #Patch Set 3 : use actual native backing size and mask out corners on mac. #Patch Set 4 : sync to changes in parent patches. #Patch Set 5 : fix device_scale_factor rounding issues for expected screenshot size. #Patch Set 6 : refactor test to exercise different box/screenshot sizes. #Patch Set 7 : update comment. #Patch Set 8 : sync. #Messages
Total messages: 70 (64 generated)
Description was changed from ========== Adds test for screenshot area capturing. BUG= ========== to ========== Adds test for screenshot area capturing. DO NOT SUBMIT: Currently based on two other patches that add required devtools commands. For the time beeing, this patch is only to illustrate their use in content/browser/devtools/protocol/devtools_protocol_browsertest.cc. BUG= ==========
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Patchset #3 (id:40001) has been deleted
Patchset #2 (id:20001) has been deleted
Description was changed from ========== Adds test for screenshot area capturing. DO NOT SUBMIT: Currently based on two other patches that add required devtools commands. For the time beeing, this patch is only to illustrate their use in content/browser/devtools/protocol/devtools_protocol_browsertest.cc. BUG= ========== to ========== Adds test for screenshot area capturing. Currently based on two other patches that add required devtools commands. For the time beeing, this patch is only to illustrate their use in content/browser/devtools/protocol/devtools_protocol_browsertest.cc. BUG= ==========
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Patchset #3 (id:80001) has been deleted
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Patchset #3 (id:100001) has been deleted
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #3 (id:120001) has been deleted
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Exceeded global retry quota
Patchset #4 (id:160001) has been deleted
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #6 (id:220001) has been deleted
Patchset #6 (id:240001) has been deleted
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
Patchset #6 (id:260001) has been deleted
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Patchset #6 (id:280001) has been deleted
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Adds test for screenshot area capturing. Currently based on two other patches that add required devtools commands. For the time beeing, this patch is only to illustrate their use in content/browser/devtools/protocol/devtools_protocol_browsertest.cc. BUG= ========== to ========== Adds a test for screenshot area capturing. Currently based on https://codereview.chromium.org/2237433004/, which adds the required forceViewport DevTools command. Also refactors the original screenshot test and re-enables it for Android. BUG=625577 ==========
Description was changed from ========== Adds a test for screenshot area capturing. Currently based on https://codereview.chromium.org/2237433004/, which adds the required forceViewport DevTools command. Also refactors the original screenshot test and re-enables it for Android. BUG=625577 ========== to ========== Adds a test for screenshot area capturing. Currently based on https://codereview.chromium.org/2237433004/, which adds the required forceViewport DevTools command. Also refactors the original screenshot test and re-enables it for Android. BUG=625577 ==========
Description was changed from ========== Adds a test for screenshot area capturing. Currently based on https://codereview.chromium.org/2237433004/, which adds the required forceViewport DevTools command. Also refactors the original screenshot test and re-enables it for Android. BUG=625577 ========== to ========== Adds a test for screenshot area capturing. Currently based on https://codereview.chromium.org/2237433004/, which adds the required forceViewport DevTools command. Also refactors the original screenshot test and re-enables it for Android. BUG=625577 ==========
eseckler@chromium.org changed reviewers: + dgozman@chromium.org
Dmitry, PTAL when convenient. I'm out for the next two weeks, so no need to rush :) Should now pass on all platforms (area screenshotting doesn't work on Android though, because setVisibleSize is not supported there).
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm. Thank you for extensive test coverage!
The CQ bit was checked by skyostil@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2237433004 Patch 240001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by eseckler@chromium.org
The CQ bit was checked by eseckler@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org Link to the patchset: https://codereview.chromium.org/2254923002/#ps340001 (title: "sync.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Adds a test for screenshot area capturing. Currently based on https://codereview.chromium.org/2237433004/, which adds the required forceViewport DevTools command. Also refactors the original screenshot test and re-enables it for Android. BUG=625577 ========== to ========== Adds a test for screenshot area capturing. Based on https://codereview.chromium.org/2237433004/, which adds the required forceViewport DevTools command. Also refactors the original screenshot test and re-enables it for Android. BUG=625577 ==========
Message was sent while issue was closed.
Description was changed from ========== Adds a test for screenshot area capturing. Based on https://codereview.chromium.org/2237433004/, which adds the required forceViewport DevTools command. Also refactors the original screenshot test and re-enables it for Android. BUG=625577 ========== to ========== Adds a test for screenshot area capturing. Based on https://codereview.chromium.org/2237433004/, which adds the required forceViewport DevTools command. Also refactors the original screenshot test and re-enables it for Android. BUG=625577 ==========
Message was sent while issue was closed.
Committed patchset #8 (id:340001)
Message was sent while issue was closed.
Description was changed from ========== Adds a test for screenshot area capturing. Based on https://codereview.chromium.org/2237433004/, which adds the required forceViewport DevTools command. Also refactors the original screenshot test and re-enables it for Android. BUG=625577 ========== to ========== Adds a test for screenshot area capturing. Based on https://codereview.chromium.org/2237433004/, which adds the required forceViewport DevTools command. Also refactors the original screenshot test and re-enables it for Android. BUG=625577 Committed: https://crrev.com/503266cd434ea508d17e6698c15da481b42ab095 Cr-Commit-Position: refs/heads/master@{#420317} ==========
Message was sent while issue was closed.
Patchset 8 (id:??) landed as https://crrev.com/503266cd434ea508d17e6698c15da481b42ab095 Cr-Commit-Position: refs/heads/master@{#420317} |
