Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: headless/lib/headless_devtools_client_browsertest.cc

Issue 2226323002: Resize DevTools target frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove getFrameSize, rename to setVisibleSize. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/lib/headless_devtools_client_browsertest.cc
diff --git a/headless/lib/headless_devtools_client_browsertest.cc b/headless/lib/headless_devtools_client_browsertest.cc
index 5523b159f96667e7c4e03b2dec3733c88d7f627f..aff5b8006bcea80b660c2bb9b2127fbebf8d9cda 100644
--- a/headless/lib/headless_devtools_client_browsertest.cc
+++ b/headless/lib/headless_devtools_client_browsertest.cc
@@ -5,17 +5,28 @@
#include <memory>
#include "base/json/json_reader.h"
+#include "content/public/browser/render_widget_host_view.h"
+#include "content/public/browser/web_contents.h"
#include "content/public/test/browser_test.h"
+#include "headless/lib/browser/headless_web_contents_impl.h"
#include "headless/public/domains/browser.h"
+#include "headless/public/domains/emulation.h"
#include "headless/public/domains/network.h"
#include "headless/public/domains/page.h"
#include "headless/public/domains/runtime.h"
#include "headless/public/headless_browser.h"
#include "headless/public/headless_devtools_client.h"
+#include "headless/public/headless_devtools_target.h"
#include "headless/test/headless_browser_test.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
+#define EXPECT_SIZE_EQ(expected, actual) \
+ do { \
+ EXPECT_EQ((expected).width(), (actual).width()); \
+ EXPECT_EQ((expected).height(), (actual).height()); \
+ } while (false)
+
namespace headless {
namespace {
@@ -212,6 +223,13 @@ class BrowserDomainCreateAndDeletePageTest
std::unique_ptr<browser::CreateTargetResult> result) {
EXPECT_EQ(2u, GetAllWebContents(browser()).size());
+ HeadlessWebContentsImpl* contents = HeadlessWebContentsImpl::From(
+ browser()->GetWebContentsForDevToolsAgentHostId(result->GetTargetId()));
+ EXPECT_SIZE_EQ(gfx::Size(1, 1), contents->web_contents()
+ ->GetRenderWidgetHostView()
+ ->GetViewBounds()
+ .size());
+
devtools_client_->GetBrowser()->GetExperimental()->CloseTarget(
browser::CloseTargetParams::Builder()
.SetTargetId(result->GetTargetId())

Powered by Google App Engine
This is Rietveld 408576698