Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: headless/lib/headless_devtools_client_browsertest.cc

Issue 2226323002: Resize DevTools target frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove getFrameSize, rename to setVisibleSize. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <memory> 5 #include <memory>
6 6
7 #include "base/json/json_reader.h" 7 #include "base/json/json_reader.h"
8 #include "content/public/browser/render_widget_host_view.h"
9 #include "content/public/browser/web_contents.h"
8 #include "content/public/test/browser_test.h" 10 #include "content/public/test/browser_test.h"
11 #include "headless/lib/browser/headless_web_contents_impl.h"
9 #include "headless/public/domains/browser.h" 12 #include "headless/public/domains/browser.h"
13 #include "headless/public/domains/emulation.h"
10 #include "headless/public/domains/network.h" 14 #include "headless/public/domains/network.h"
11 #include "headless/public/domains/page.h" 15 #include "headless/public/domains/page.h"
12 #include "headless/public/domains/runtime.h" 16 #include "headless/public/domains/runtime.h"
13 #include "headless/public/headless_browser.h" 17 #include "headless/public/headless_browser.h"
14 #include "headless/public/headless_devtools_client.h" 18 #include "headless/public/headless_devtools_client.h"
19 #include "headless/public/headless_devtools_target.h"
15 #include "headless/test/headless_browser_test.h" 20 #include "headless/test/headless_browser_test.h"
16 #include "testing/gtest/include/gtest/gtest.h" 21 #include "testing/gtest/include/gtest/gtest.h"
17 #include "url/gurl.h" 22 #include "url/gurl.h"
18 23
24 #define EXPECT_SIZE_EQ(expected, actual) \
25 do { \
26 EXPECT_EQ((expected).width(), (actual).width()); \
27 EXPECT_EQ((expected).height(), (actual).height()); \
28 } while (false)
29
19 namespace headless { 30 namespace headless {
20 31
21 namespace { 32 namespace {
22 33
23 std::vector<HeadlessWebContents*> GetAllWebContents(HeadlessBrowser* browser) { 34 std::vector<HeadlessWebContents*> GetAllWebContents(HeadlessBrowser* browser) {
24 std::vector<HeadlessWebContents*> result; 35 std::vector<HeadlessWebContents*> result;
25 36
26 for (HeadlessBrowserContext* browser_context : 37 for (HeadlessBrowserContext* browser_context :
27 browser->GetAllBrowserContexts()) { 38 browser->GetAllBrowserContexts()) {
28 std::vector<HeadlessWebContents*> web_contents = 39 std::vector<HeadlessWebContents*> web_contents =
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 .SetHeight(1) 216 .SetHeight(1)
206 .Build(), 217 .Build(),
207 base::Bind(&BrowserDomainCreateAndDeletePageTest::OnCreateTargetResult, 218 base::Bind(&BrowserDomainCreateAndDeletePageTest::OnCreateTargetResult,
208 base::Unretained(this))); 219 base::Unretained(this)));
209 } 220 }
210 221
211 void OnCreateTargetResult( 222 void OnCreateTargetResult(
212 std::unique_ptr<browser::CreateTargetResult> result) { 223 std::unique_ptr<browser::CreateTargetResult> result) {
213 EXPECT_EQ(2u, GetAllWebContents(browser()).size()); 224 EXPECT_EQ(2u, GetAllWebContents(browser()).size());
214 225
226 HeadlessWebContentsImpl* contents = HeadlessWebContentsImpl::From(
227 browser()->GetWebContentsForDevToolsAgentHostId(result->GetTargetId()));
228 EXPECT_SIZE_EQ(gfx::Size(1, 1), contents->web_contents()
229 ->GetRenderWidgetHostView()
230 ->GetViewBounds()
231 .size());
232
215 devtools_client_->GetBrowser()->GetExperimental()->CloseTarget( 233 devtools_client_->GetBrowser()->GetExperimental()->CloseTarget(
216 browser::CloseTargetParams::Builder() 234 browser::CloseTargetParams::Builder()
217 .SetTargetId(result->GetTargetId()) 235 .SetTargetId(result->GetTargetId())
218 .Build(), 236 .Build(),
219 base::Bind(&BrowserDomainCreateAndDeletePageTest::OnCloseTargetResult, 237 base::Bind(&BrowserDomainCreateAndDeletePageTest::OnCloseTargetResult,
220 base::Unretained(this))); 238 base::Unretained(this)));
221 } 239 }
222 240
223 void OnCloseTargetResult(std::unique_ptr<browser::CloseTargetResult> result) { 241 void OnCloseTargetResult(std::unique_ptr<browser::CloseTargetResult> result) {
224 EXPECT_TRUE(result->GetSuccess()); 242 EXPECT_TRUE(result->GetSuccess());
(...skipping 388 matching lines...) Expand 10 before | Expand all | Expand 10 after
613 FinishAsynchronousTest(); 631 FinishAsynchronousTest();
614 } 632 }
615 633
616 private: 634 private:
617 bool navigation_requested_ = false; 635 bool navigation_requested_ = false;
618 }; 636 };
619 637
620 HEADLESS_ASYNC_DEVTOOLED_TEST_F(HeadlessDevToolsNavigationControlTest); 638 HEADLESS_ASYNC_DEVTOOLED_TEST_F(HeadlessDevToolsNavigationControlTest);
621 639
622 } // namespace headless 640 } // namespace headless
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698