Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 222103008: Revert r258965 aka reland r258122 (Closed)

Created:
6 years, 8 months ago by no sievers
Modified:
6 years, 8 months ago
Reviewers:
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

Revert r258965 aka reland r258122 gpu: Allow fences to check whether a flush has occurred This skips waiting on a fence that was created but never committed. BUG=352419, 355275 TBR=piman@chromium.org > Original Review URL: https://codereview.chromium.org/197563003 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -27 lines) Patch
M gpu/command_buffer/service/mailbox_manager_unittest.cc View 8 chunks +8 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/mailbox_synchronizer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/texture_definition.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M ui/gl/gl_context.h View 4 chunks +26 lines, -0 lines 0 comments Download
M ui/gl/gl_context.cc View 3 chunks +27 lines, -0 lines 0 comments Download
M ui/gl/gl_fence.h View 1 chunk +6 lines, -1 line 0 comments Download
M ui/gl/gl_fence.cc View 8 chunks +47 lines, -12 lines 0 comments Download
M ui/gl/gl_gl_api_implementation.h View 3 chunks +8 lines, -1 line 0 comments Download
M ui/gl/gl_gl_api_implementation.cc View 3 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
no sievers
The CQ bit was checked by sievers@chromium.org
6 years, 8 months ago (2014-04-02 23:12:02 UTC) #1
no sievers
The CQ bit was unchecked by sievers@chromium.org
6 years, 8 months ago (2014-04-02 23:12:15 UTC) #2
no sievers
The CQ bit was checked by sievers@chromium.org
6 years, 8 months ago (2014-04-03 02:02:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/222103008/1
6 years, 8 months ago (2014-04-03 02:09:44 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 08:33:01 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 08:33:01 UTC) #6
no sievers
The CQ bit was checked by sievers@chromium.org
6 years, 8 months ago (2014-04-03 14:40:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/222103008/1
6 years, 8 months ago (2014-04-03 14:42:29 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 14:45:03 UTC) #9
Message was sent while issue was closed.
Change committed as 261383

Powered by Google App Engine
This is Rietveld 408576698