Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2220603002: rename FoceCopyMode to SkCopyPixelMode (Closed)

Created:
4 years, 4 months ago by reed1
Modified:
4 years, 4 months ago
Reviewers:
f(malita), djsollen, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : require copymode param to MakeBitmapShader internal api #

Patch Set 3 : manual rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -133 lines) Patch
M gm/lightingshader.cpp View 1 2 chunks +4 lines, -6 lines 0 comments Download
M gm/lightingshader2.cpp View 1 2 chunks +7 lines, -8 lines 0 comments Download
M gm/lightingshaderbevel.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M samplecode/SampleLighting.cpp View 1 2 chunks +3 lines, -4 lines 0 comments Download
M samplecode/SampleLitAtlas.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapProcShader.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/core/SkDraw.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download
A + src/core/SkImagePriv.h View 1 2 chunks +8 lines, -8 lines 0 comments Download
M src/core/SkShader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/image/SkImagePriv.h View 1 1 chunk +0 lines, -63 lines 0 comments Download
M src/image/SkImageShader.cpp View 1 1 chunk +8 lines, -3 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M src/image/SkSurface_Base.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/image/SkSurface_Gpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkSurface_Gpu.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/image/SkSurface_Raster.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/ImageTest.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M tests/SerializationTest.cpp View 1 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
reed1
4 years, 4 months ago (2016-08-05 17:23:41 UTC) #6
f(malita)
LGTM % remaining build fixes
4 years, 4 months ago (2016-08-05 17:36:19 UTC) #13
reed1
On 2016/08/05 17:36:19, f(malita) wrote: > LGTM % remaining build fixes yea, rebase issue w/ ...
4 years, 4 months ago (2016-08-05 18:43:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220603002/40001
4 years, 4 months ago (2016-08-05 18:48:30 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/1ec04d9553af68b458c8dd6bd18d8c25ebd41d7a
4 years, 4 months ago (2016-08-05 19:07:44 UTC) #19
djsollen
4 years, 4 months ago (2016-08-08 02:41:06 UTC) #21
Message was sent while issue was closed.
this unfortunately broke the android framework build as they are using that
flag.  I'll upload a CL for them to use the new name.

Powered by Google App Engine
This is Rietveld 408576698