Timeline: show white overlay till page being reloaded paints

Timeline: show white overlay till page being reloaded paints

This is so that the reload progress is better seen both interactively
and on the screenshots -- otherwise the old content of the page being
reloaded stays on the screen and makes screenshots confusing.

Committed: https://crrev.com/979f3764fb511923218a33f79acae484c4edbe29
Cr-Commit-Position: refs/heads/master@{#413304}

[caseq, 2016-08-05 21:31:00]

Patchset #1 (id:1) has been deleted

[caseq, 2016-08-05 21:56:13]

Patchset #1 (id:20001) has been deleted

[caseq, 2016-08-05 22:01:44]

caseq@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[dgozman, 2016-08-08 16:28:00]

Can we have a screenshot? And a bug?

https://codereview.chromium.org/2218603003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/browser_protocol.json (right):

https://codereview.chromium.org/2218603003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/browser_protocol.json:3835: { "name":
"reloadingBannerMessage", "type": "string", "optional": true, "description":
"Banner text to display in the overlay before newly reloaded page has produced
any output." }
Why is this tracing-specific? What if reload doesn't happen while recording?

https://codereview.chromium.org/2218603003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/InspectorOverlay.h (right):

https://codereview.chromium.org/2218603003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/InspectorOverlay.h:97: enum class MessageType {
Can we have a single message?

[caseq, 2016-08-08 17:49:16]

On 2016/08/08 16:28:00, dgozman wrote:
> Can we have a screenshot? And a bug?
> 
>
https://codereview.chromium.org/2218603003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/inspector/browser_protocol.json (right):
> 
>
https://codereview.chromium.org/2218603003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/inspector/browser_protocol.json:3835: { "name":
> "reloadingBannerMessage", "type": "string", "optional": true, "description":
> "Banner text to display in the overlay before newly reloaded page has produced
> any output." }
> Why is this tracing-specific? What if reload doesn't happen while recording?

As discussed with pfeldman -- we want to make it a bit simpler for existing
tracing client.

>
https://codereview.chromium.org/2218603003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/web/InspectorOverlay.h (right):
> 
>
https://codereview.chromium.org/2218603003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/web/InspectorOverlay.h:97: enum class MessageType {
> Can we have a single message?

They have different semantics, this one is rendered differently (spans the
entire screen) and should be automatically removed when new page starts
rendering.

[caseq, 2016-08-09 23:32:57]

Simplified to remove message and any explicit mentioning in the protocol.
Dmitry, here's a screenshot for you:

+--------------------------+
|                          |
|                          |
|                          |
|                          |
|                          |
|                          |
+--------------------------+

[dgozman, 2016-08-10 21:28:37]

https://codereview.chromium.org/2218603003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp (right):

https://codereview.chromium.org/2218603003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp:421:
m_client->willReloadPage();
What if we reload not through the protocol? Also, maybe do similar thing for
navigations?

https://codereview.chromium.org/2218603003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/InspectorOverlay.cpp (right):

https://codereview.chromium.org/2218603003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/InspectorOverlay.cpp:703: m_suspended = true;
This code looks strange.

[caseq, 2016-08-11 01:51:49]

Patchset #4 (id:100001) has been deleted

[caseq, 2016-08-11 01:52:44]

PTAL -- as discussed with Pavel, moved all logic into InspectorTracingAgent,
plumbing instrumentation signals there as necessary.

[dgozman, 2016-08-11 01:57:19]

lgtm. Thanks!

[dgozman, 2016-08-11 01:57:34]

Patch description is wrong though.

[caseq, 2016-08-11 01:57:40]

The CQ bit was checked by caseq@chromium.org

[caseq, 2016-08-11 01:57:47]

The CQ bit was unchecked by caseq@chromium.org

[caseq, 2016-08-11 01:58:38]

Description was changed from

==========
Timeline: show "Reloading..." banner in overlay till page being reloaded paints

- add reloadingBannerMessage parameter to Tracing.start
- display the banner in the overflow from the moment tracing is started till
    the navigation is committed and we clear the root layer of the page.

This is so that the reload progress is better seen both interactively
and on the screenshots -- otherwise the old content of the page being
reloaded stays on the screen and makes screenshots confusing.
==========

to

==========
Timeline: show white overlay till page being reloaded paints

This is so that the reload progress is better seen both interactively
and on the screenshots -- otherwise the old content of the page being
reloaded stays on the screen and makes screenshots confusing.
==========

[caseq, 2016-08-11 01:58:52]

On 2016/08/11 01:57:34, dgozman wrote:
> Patch description is wrong though.

Ouch, thanks for spotting!

[caseq, 2016-08-11 01:58:57]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2016-08-11 01:59:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 03:36:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 03:36:26]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[caseq, 2016-08-15 18:54:26]

The CQ bit was checked by caseq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 18:54:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 20:41:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 20:41:53]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[caseq, 2016-08-18 20:43:01]

The CQ bit was checked by caseq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 20:43:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 22:38:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 22:38:56]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[caseq, 2016-08-18 23:13:47]

The CQ bit was checked by caseq@chromium.org

[caseq, 2016-08-18 23:13:47]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2218603003/#ps140001
(title: "rebased, dropped console.error() upon paint with 0 layer")

[commit-bot: I haz the power, 2016-08-18 23:14:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 02:57:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 02:57:39]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[caseq, 2016-08-19 17:33:16]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2016-08-19 17:33:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 20:35:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 20:35:14]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[caseq, 2016-08-19 20:35:40]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2016-08-19 20:36:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 01:34:41]

Description was changed from

==========
Timeline: show white overlay till page being reloaded paints

This is so that the reload progress is better seen both interactively
and on the screenshots -- otherwise the old content of the page being
reloaded stays on the screen and makes screenshots confusing.
==========

to

==========
Timeline: show white overlay till page being reloaded paints

This is so that the reload progress is better seen both interactively
and on the screenshots -- otherwise the old content of the page being
reloaded stays on the screen and makes screenshots confusing.
==========

[commit-bot: I haz the power, 2016-08-20 01:34:42]

Committed patchset #5 (id:140001)

[commit-bot: I haz the power, 2016-08-20 01:36:17]

Description was changed from

==========
Timeline: show white overlay till page being reloaded paints

This is so that the reload progress is better seen both interactively
and on the screenshots -- otherwise the old content of the page being
reloaded stays on the screen and makes screenshots confusing.
==========

to

==========
Timeline: show white overlay till page being reloaded paints

This is so that the reload progress is better seen both interactively
and on the screenshots -- otherwise the old content of the page being
reloaded stays on the screen and makes screenshots confusing.

Committed: https://crrev.com/979f3764fb511923218a33f79acae484c4edbe29
Cr-Commit-Position: refs/heads/master@{#413304}
==========

[commit-bot: I haz the power, 2016-08-20 01:36:18]

Patchset 5 (id:??) landed as
https://crrev.com/979f3764fb511923218a33f79acae484c4edbe29
Cr-Commit-Position: refs/heads/master@{#413304}