Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2218603003: Timeline: show white overlay till page being reloaded paints (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased, dropped console.error() upon paint with 0 layer Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 4257 matching lines...) Expand 10 before | Expand all | Expand 10 after
4268 } else { 4268 } else {
4269 m_rootGraphicsLayer = nullptr; 4269 m_rootGraphicsLayer = nullptr;
4270 m_visualViewportContainerLayer = nullptr; 4270 m_visualViewportContainerLayer = nullptr;
4271 m_rootLayer = nullptr; 4271 m_rootLayer = nullptr;
4272 // This means that we're transitioning to a new page. Suppress 4272 // This means that we're transitioning to a new page. Suppress
4273 // commits until Blink generates invalidations so we don't 4273 // commits until Blink generates invalidations so we don't
4274 // attempt to paint too early in the next page load. 4274 // attempt to paint too early in the next page load.
4275 m_layerTreeView->setDeferCommits(true); 4275 m_layerTreeView->setDeferCommits(true);
4276 m_layerTreeView->clearRootLayer(); 4276 m_layerTreeView->clearRootLayer();
4277 m_layerTreeView->clearViewportLayers(); 4277 m_layerTreeView->clearViewportLayers();
4278 if (WebDevToolsAgentImpl* devTools = mainFrameDevToolsAgentImpl())
4279 devTools->rootLayerCleared();
4278 } 4280 }
4279 } 4281 }
4280 4282
4281 void WebViewImpl::invalidateRect(const IntRect& rect) 4283 void WebViewImpl::invalidateRect(const IntRect& rect)
4282 { 4284 {
4283 if (m_layerTreeView) { 4285 if (m_layerTreeView) {
4284 updateLayerTreeViewport(); 4286 updateLayerTreeViewport();
4285 } else if (m_client) { 4287 } else if (m_client) {
4286 // This is only for WebViewPlugin. 4288 // This is only for WebViewPlugin.
4287 m_client->widgetClient()->didInvalidateRect(rect); 4289 m_client->widgetClient()->didInvalidateRect(rect);
(...skipping 312 matching lines...) Expand 10 before | Expand all | Expand 10 after
4600 return nullptr; 4602 return nullptr;
4601 return focusedFrame; 4603 return focusedFrame;
4602 } 4604 }
4603 4605
4604 LocalFrame* WebViewImpl::focusedLocalFrameAvailableForIme() const 4606 LocalFrame* WebViewImpl::focusedLocalFrameAvailableForIme() const
4605 { 4607 {
4606 return m_imeAcceptEvents ? focusedLocalFrameInWidget() : nullptr; 4608 return m_imeAcceptEvents ? focusedLocalFrameInWidget() : nullptr;
4607 } 4609 }
4608 4610
4609 } // namespace blink 4611 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698