Timeline: show white overlay till page being reloaded paints

third_party/WebKit/Source/web/InspectorOverlay.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 161 matching lines @@
 
 
 InspectorOverlay::InspectorOverlay(WebViewImpl* webViewImpl)
     : m_webViewImpl(webViewImpl)
     , m_overlayHost(InspectorOverlayHost::create())
     , m_drawViewSize(false)
     , m_resizeTimerActive(false)
     , m_omitTooltip(false)
     , m_timer(this, &InspectorOverlay::onTimer)
     , m_suspended(false)
+    , m_showReloadingBlanket(false)
     , m_inLayout(false)
     , m_needsUpdate(false)
     , m_inspectMode(InspectorDOMAgent::NotSearching)
 {
 }
 
 InspectorOverlay::~InspectorOverlay()
 {
     DCHECK(!m_overlayPage);
 }
@@ skipping 95 matching lines @@
 
     return handled;
 }
 
 void InspectorOverlay::setPausedInDebuggerMessage(const String& message)
 {
     m_pausedInDebuggerMessage = message;
     scheduleUpdate();
 }
 
+void InspectorOverlay::showReloadingBlanket()
+{
+    m_showReloadingBlanket = true;
+    scheduleUpdate();
+}
+
+void InspectorOverlay::maybeClearReloadingBlanket()
+{
+    if (!m_showReloadingBlanket)
+        return;
+    m_showReloadingBlanket = false;
+    if (m_suspended)
+        clearInternal();
+    else
+        scheduleUpdate();
+}
+
 void InspectorOverlay::hideHighlight()
 {
     m_highlightNode.clear();
     m_eventTargetNode.clear();
     m_highlightQuad.reset();
     scheduleUpdate();
 }
 
 void InspectorOverlay::highlightNode(Node* node, const InspectorHighlightConfig& highlightConfig, bool omitTooltip)
 {
@@ skipping 40 matching lines @@
 void InspectorOverlay::highlightQuad(std::unique_ptr<FloatQuad> quad, const InspectorHighlightConfig& highlightConfig)
 {
     m_quadHighlightConfig = highlightConfig;
     m_highlightQuad = std::move(quad);
     m_omitTooltip = false;
     scheduleUpdate();
 }
 
 bool InspectorOverlay::isEmpty()
 {
+    if (m_showReloadingBlanket)
+        return false;
     if (m_suspended)
         return true;
     bool hasVisibleElements = m_highlightNode || m_eventTargetNode || m_highlightQuad  || (m_resizeTimerActive && m_drawViewSize) || !m_pausedInDebuggerMessage.isNull();
     return !hasVisibleElements && m_inspectMode == InspectorDOMAgent::NotSearching;
 }
 
 void InspectorOverlay::scheduleUpdate()
 {
     if (isEmpty()) {
         if (m_pageOverlay)
@@ skipping 14 matching lines @@
 
     IntRect visibleRectInDocument = view->getScrollableArea()->visibleContentRect();
     IntSize viewportSize = m_webViewImpl->page()->frameHost().visualViewport().size();
     LocalFrame* frame = toLocalFrame(overlayPage()->mainFrame());
     frame->view()->resize(viewportSize);
     overlayPage()->frameHost().visualViewport().setSize(viewportSize);
     frame->setPageZoomFactor(windowToViewportScale());
 
     reset(viewportSize, visibleRectInDocument.location());
 
+    if (m_showReloadingBlanket) {
+        evaluateInOverlay("showReloadingBlanket", "");
+        return;
+    }
     drawNodeHighlight();
     drawQuadHighlight();
     drawPausedInDebuggerMessage();
     drawViewSize();
     if (m_layoutEditor && !m_highlightNode)
         m_layoutEditor->rebuild();
 }
 
 static std::unique_ptr<protocol::DictionaryValue> buildObjectForSize(const IntSize& size)
 {
@@ skipping 268 matching lines @@
     toChromeClientImpl(m_webViewImpl->page()->chromeClient()).setCursorOverridden(false);
     toChromeClientImpl(m_webViewImpl->page()->chromeClient()).setCursor(pointerCursor(), overlayMainFrame());
 }
 
 void InspectorOverlay::suspend()
 {
     if (!m_suspended) {
         m_suspended = true;
         clearInternal();
     }
+    m_suspended = true;

[dgozman, 2016/08/10 21:28:37]

This code looks strange.

+    clearInternal();
 }
 
 void InspectorOverlay::resume()
 {
     m_suspended = false;
 }
 
 void InspectorOverlay::pageLayoutInvalidated(bool resized)
 {
     if (resized && m_drawViewSize) {
@@ skipping 101 matching lines @@
 
 void InspectorOverlay::initializeLayoutEditorIfNeeded(Node* node)
 {
     if (m_inspectMode != InspectorDOMAgent::ShowLayoutEditor || !node || !node->isElementNode() || !node->ownerDocument()->isActive() || !m_cssAgent || !m_domAgent)
         return;
     m_layoutEditor = LayoutEditor::create(toElement(node), m_cssAgent, m_domAgent, &overlayMainFrame()->script());
     toChromeClientImpl(m_webViewImpl->page()->chromeClient()).setCursorOverridden(true);
 }
 
 } // namespace blink