third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js - Issue 2218603003: Timeline: show white overlay till page being reloaded paints

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

Issue 2218603003: Timeline: show white overlay till page being reloaded paints (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased, dropped console.error() upon paint with 0 layer Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp ('k') | third_party/WebKit/Source/web/InspectorOverlay.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js b/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

index 0c1fece45d0aa5e9223139f07af38ff4c34628df..491ecee9ad09c5d37e17e2585c13db4d9fc4fafb 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

@@ -1653,10 +1653,10 @@ WebInspector.InvalidationTracker.prototype = {

var layerId = paintEvent.args["data"]["layerId"];

if (layerId)

this._lastPaintWithLayer = paintEvent;

- if (!this._lastPaintWithLayer) {

- console.error("Failed to find a paint container for a paint event.");

+ // Quietly discard top-level paints without layerId, as these are likely

+ // to come from overlay.

+ if (!this._lastPaintWithLayer)

return;

- }

var effectivePaintId = this._lastPaintWithLayer.args["data"]["nodeId"];

var paintFrameId = paintEvent.args["data"]["frame"];