Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h

Issue 2218603003: Timeline: show white overlay till page being reloaded paints (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased, dropped console.error() upon paint with 0 layer Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h
index a4a1011a76cef3540167c6e68d04ab77f5110252..a050fbb26ac3ba68f44f86cc2f6fbfd905aba792 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h
@@ -25,8 +25,10 @@ public:
public:
virtual ~Client() { }
- virtual void enableTracing(const String& categoryFilter) { }
- virtual void disableTracing() { }
+ virtual void enableTracing(const String& categoryFilter) = 0;
+ virtual void disableTracing() = 0;
+ virtual void showReloadingBlanket() = 0;
+ virtual void hideReloadingBlanket() = 0;
};
static InspectorTracingAgent* create(Client* client, InspectorWorkerAgent* workerAgent, InspectedFrames* inspectedFrames)
@@ -40,19 +42,25 @@ public:
void restore() override;
void disable(ErrorString*) override;
+ // InspectorInstrumentation methods
+ void frameStartedLoading(LocalFrame*);
+ void frameStoppedLoading(LocalFrame*);
+
// Protocol method implementations.
void start(const Maybe<String>& categories, const Maybe<String>& options, const Maybe<double>& bufferUsageReportingInterval, const Maybe<String>& transferMode, const Maybe<protocol::Tracing::TraceConfig>&, std::unique_ptr<StartCallback>) override;
void end(std::unique_ptr<EndCallback>) override;
// Methods for other agents to use.
void setLayerTreeId(int);
+ void rootLayerCleared();
private:
InspectorTracingAgent(Client*, InspectorWorkerAgent*, InspectedFrames*);
void emitMetadataEvents();
- void resetSessionId();
- String sessionId();
+ void innerDisable();
+ String sessionId() const;
+ bool isStarted() const;
int m_layerTreeId;
Client* m_client;

Powered by Google App Engine
This is Rietveld 408576698